From owner-freebsd-acpi@FreeBSD.ORG Sat Jun 2 16:37:26 2012 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA46C106566C for ; Sat, 2 Jun 2012 16:37:26 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 645868FC0C for ; Sat, 2 Jun 2012 16:37:26 +0000 (UTC) Received: by laai10 with SMTP id i10so2816053laa.13 for ; Sat, 02 Jun 2012 09:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=nrFZyJ7DodW3oZNF4tb8QTh7iSqubFnx+hKBvrJK4Bs=; b=kDE1Q6HTUNdGXmnXL8Wox5UwP3Z76ZX+YqnwWL9YJlrWyg922MHCz4OqyU2slKVPkc cINCGjgCHm7gs665D1o0cTsdc7IE8Es8e8eUlkbsH2zOtLzrwGW9jucO0sNN1hcyeqpu GSWM5jBY1UOm3dAQ5In3vLmx1Q+dq9EQ18MBqUIw/I3JhmYTR4Rn+BHeu9XibL13Eevp tLx8jOaxJaGKqO5Gt0tcx15K3fWY9JKHlixquluWyqMiUXu3SG7zgTf9dk78T3uOWj4d 0kRzzn076nG3vKq1tI/JDpaNhnSodUyHvqfiEDe4hpMHuRuL/pcuYaRhfNOCAoJ8mUkM W2SA== MIME-Version: 1.0 Received: by 10.112.42.34 with SMTP id k2mr3754861lbl.0.1338655045006; Sat, 02 Jun 2012 09:37:25 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.112.27.65 with HTTP; Sat, 2 Jun 2012 09:37:24 -0700 (PDT) In-Reply-To: <20120603.002554.119853142.iwasaki@jp.FreeBSD.org> References: <20120603.002554.119853142.iwasaki@jp.FreeBSD.org> Date: Sat, 2 Jun 2012 17:37:24 +0100 X-Google-Sender-Auth: fpODTT12zDZHsKQqMZLijDOhmEM Message-ID: From: Attilio Rao To: Mitsuru IWASAKI Content-Type: text/plain; charset=UTF-8 Cc: freebsd-acpi@freebsd.org Subject: Re: preparation for x86/acpica/acpi_wakeup.c X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jun 2012 16:37:27 -0000 2012/6/2 Mitsuru IWASAKI : > Hi, > > Well I think we are ready to have x86/acpica/acpi_wakeup.c to share > acpi_sleep_machdep() and acpi_wakeup_machdep() between amd64 and i386. > > http://people.freebsd.org/~iwasaki/acpi/x86-acpi_wakeup-20120602.diff IWASAKI-san, the move of the file makes most of the patch to acpi_wakeup.c unreadable (in order to determine the code changing for adaping back and forth from i386 to amd64). For the sake of reviewers, can you please simply patch the amd64 version in a way that it shows clearly the changes to get i386 (or the other way around)? Attilio -- Peace can only be achieved by understanding - A. Einstein