From owner-freebsd-gnome@FreeBSD.ORG Thu Dec 27 12:37:17 2007 Return-Path: Delivered-To: freebsd-gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7C1E616A468; Thu, 27 Dec 2007 12:37:17 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id 2BAB513C46A; Thu, 27 Dec 2007 12:37:17 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id 27429744004; Thu, 27 Dec 2007 14:37:15 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IT2JsJjP1GKu; Thu, 27 Dec 2007 14:37:14 +0200 (EET) Received: from [10.2.1.87] (gateway.cybervisiontech.com.ua [88.81.251.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id B1ABB744003; Thu, 27 Dec 2007 14:37:14 +0200 (EET) Message-ID: <47739C79.2080508@icyb.net.ua> Date: Thu, 27 Dec 2007 14:37:13 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20071116) MIME-Version: 1.0 To: Joe Marcus Clarke Content-Type: multipart/mixed; boundary="------------020905010203020500070605" Cc: freebsd-gnome@freebsd.org Subject: hald patch: quieter audio cd probing X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2007 12:37:17 -0000 This is a multi-part message in MIME format. --------------020905010203020500070605 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit With the attached patched I eliminated "Illegal mode for this track" messages while hald probes audio cd. The idea was that if cdrom doesn't have any data tracks then we should not try to find any volumes on it. -- Andriy Gapon --------------020905010203020500070605 Content-Type: text/x-patch; name="patch-audio-cd.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="patch-audio-cd.patch" --- hald/freebsd/probing/probe-volume.c.orig Thu Dec 27 14:26:03 2007 +++ hald/freebsd/probing/probe-volume.c Thu Dec 27 14:27:22 2007 @@ -377,7 +377,7 @@ * is a swap partition, we probe it nevertheless in case the * partition type is incorrect. */ - if (! has_children) + if (! has_children && ! (is_cdrom && ! has_data)) { vid = volume_id_open_fd(fd); if (vid) --------------020905010203020500070605--