From nobody Mon Jul 7 15:07:47 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbSKJ4SLlz61w7V; Mon, 07 Jul 2025 15:07:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbSKJ16nJz3wPm; Mon, 07 Jul 2025 15:07:48 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Za52I7S9gJ36yteNGyb+i/aQNeoO4hQ44QKPYQpMGTQ=; b=YwCi3WxLGJmcn1Kgv7fL8qlZL28KmTCkC6oxUHiHrtjJD1E9EWdQcQX3povFaNfquPq5d2 9xCktHGCDg5q0PmjZvdlckRIQQkV0baiUbVs7sZ5JfumsGlV/LMiw9lC1FDIFo/OL07ekp Qnns19c1lAwDUVrg6gqdly2moIAYO+dOfsSetPYS3UFX3VsDONK4wbwLb8eFrIJttIstKV s8SjYT8d7l70DJxwxlsZpRul8k+vQuPkXXyOXtrv88ecOp+UfmmtqdVOa1d4XV/l1lqCPq b+X3e7JIzVKWyDYe2/zBNuYkRaKOP6Z7JtRyNIpwGhyXUcZMZwyNe3FS2d5ufA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751900868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Za52I7S9gJ36yteNGyb+i/aQNeoO4hQ44QKPYQpMGTQ=; b=gCWMQAnSkCG7dhuYw4zZGG9xOrtLrr9LAMVTEQXV8p+YmZiGpGvW8layFxhENyrUf00Tlj nZ3tGyB+ZmtH8iRC/PLMutn0c+2S+VVcuR3y3pviLGt1NzDeXCfdkJ3RmhLHVzigCEZDcS JzBKFcz9kPCSOcwXF+gwaEKP763p2wypNaKx/T93qF6degF0C2JOQoHTWGwNHtjov6braS lCZ827jhhJ+SiJ+HGgwmIBw8CHnBMqJFBlLiZXUR+hbE5qGKkkZ6F7h8OiT6WdgdDcE7aX Q4WQL7PlDkkFkEgHqSkAJkJhuXPHtgFHyb1+cFMftbm2RCHCh8SxfDSTeTserg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751900868; a=rsa-sha256; cv=none; b=LU6l9E4lrclPQK+ZbJhCY5kWR/QQfPy1TN4kpaLU7iFIqvRSGJlNHxZo/MfKmc9chFPLkq lsWC+HszZn/rcP94KVbpqSMEDzJcwDt4bJEOXWnmvlYRYN34uvb74NclDrkPViVj/4Ca8n 6Xggu1x8OjUVkiMp5kK8/P0gtTmoPJherO1kwT/aAErBjHhkMTUhtnGfJxqItGJJZ5rAC9 uOSH2O8UaUcoO+2mMUucPJ4O7oemzgUAbnY/xTCd2pdIEVL/W4/p0HXTzdhrORB8bunT7G P4PozH2O0TJ5FsfJzmExsmNHd2ffDhUtOfaN/+OlLyELlw7Ap5oes6MkKx1NhQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbSKJ0k64zwF1; Mon, 07 Jul 2025 15:07:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 567F7mY7016369; Mon, 7 Jul 2025 15:07:48 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 567F7lqs016366; Mon, 7 Jul 2025 15:07:47 GMT (envelope-from git) Date: Mon, 7 Jul 2025 15:07:47 GMT Message-Id: <202507071507.567F7lqs016366@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 82e1b49d7571 - main - pfctl: Zap unnused iface function parameter from pfctl_kill_src_nodes() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 82e1b49d75714b91052dfeaf9a8f5f94d03f77ec Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=82e1b49d75714b91052dfeaf9a8f5f94d03f77ec commit 82e1b49d75714b91052dfeaf9a8f5f94d03f77ec Author: Kristof Provost AuthorDate: 2025-07-01 09:50:17 +0000 Commit: Kristof Provost CommitDate: 2025-07-07 15:06:48 +0000 pfctl: Zap unnused iface function parameter from pfctl_kill_src_nodes() Killing source tracking entries per interface does not make sense and `-i interface' along with `-K key' is completely ignored anyway. There since import in 2006, probably just copy/pasta. OK sashan Obtained from: OpenBSD, kn , 28535c0a36 Sponsored by: Rubicon Communications, LLC ("Netgate") --- sbin/pfctl/pfctl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sbin/pfctl/pfctl.c b/sbin/pfctl/pfctl.c index 38d74aceba80..88123b17f1b3 100644 --- a/sbin/pfctl/pfctl.c +++ b/sbin/pfctl/pfctl.c @@ -78,7 +78,7 @@ int pfctl_clear_altq(int, int); void pfctl_clear_src_nodes(int, int); void pfctl_clear_iface_states(int, const char *, int); void pfctl_addrprefix(char *, struct pf_addr *); -void pfctl_kill_src_nodes(int, const char *, int); +void pfctl_kill_src_nodes(int, int); void pfctl_net_kill_states(int, const char *, int); void pfctl_gateway_kill_states(int, const char *, int); void pfctl_label_kill_states(int, const char *, int); @@ -590,7 +590,7 @@ pfctl_addrprefix(char *addr, struct pf_addr *mask) } void -pfctl_kill_src_nodes(int dev, const char *iface, int opts) +pfctl_kill_src_nodes(int dev, int opts) { struct pfioc_src_node_kill psnk; struct addrinfo *res[2], *resp[2]; @@ -3400,7 +3400,7 @@ main(int argc, char *argv[]) } if (src_node_killers) - pfctl_kill_src_nodes(dev, ifaceopt, opts); + pfctl_kill_src_nodes(dev, opts); if (tblcmdopt != NULL) { error = pfctl_table(argc, argv, tableopt,