From owner-svn-src-head@FreeBSD.ORG  Tue Oct 30 12:25:53 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 0A99E481;
 Tue, 30 Oct 2012 12:25:53 +0000 (UTC)
 (envelope-from attilio@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
 by mx1.freebsd.org (Postfix) with ESMTP id D974C8FC0A;
 Tue, 30 Oct 2012 12:25:52 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9UCPq5n088691;
 Tue, 30 Oct 2012 12:25:52 GMT (envelope-from attilio@svn.freebsd.org)
Received: (from attilio@localhost)
 by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9UCPqUq088689;
 Tue, 30 Oct 2012 12:25:52 GMT (envelope-from attilio@svn.freebsd.org)
Message-Id: <201210301225.q9UCPqUq088689@svn.freebsd.org>
From: Attilio Rao <attilio@FreeBSD.org>
Date: Tue, 30 Oct 2012 12:25:52 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r242356 - head/sys/kern
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Oct 2012 12:25:53 -0000

Author: attilio
Date: Tue Oct 30 12:25:52 2012
New Revision: 242356
URL: http://svn.freebsd.org/changeset/base/242356

Log:
  tdq_lock_pair() already does spinlock_enter() so migration is not
  possible in sched_balance_pair(). Remove redundant sched_pin().
  
  Reviewed by:	marius, jeff

Modified:
  head/sys/kern/sched_ule.c

Modified: head/sys/kern/sched_ule.c
==============================================================================
--- head/sys/kern/sched_ule.c	Tue Oct 30 11:33:47 2012	(r242355)
+++ head/sys/kern/sched_ule.c	Tue Oct 30 12:25:52 2012	(r242356)
@@ -910,10 +910,8 @@ sched_balance_pair(struct tdq *high, str
 		 * reschedule with the new workload.
 		 */
 		cpu = TDQ_ID(low);
-		sched_pin();
 		if (cpu != PCPU_GET(cpuid))
 			ipi_cpu(cpu, IPI_PREEMPT);
-		sched_unpin();
 	}
 	tdq_unlock_pair(high, low);
 	return (moved);