Date: Wed, 25 Sep 2024 14:32:00 -0600 From: Warner Losh <imp@bsdimp.com> To: Ayrton Munoz <a.munoz3327@gmail.com> Cc: Mark Millard <marklmi@yahoo.com>, "<dev-commits-src-main@freebsd.org>" <dev-commits-src-main@freebsd.org> Subject: Re: git: 85918beb387f - main - intrng: Add support for multiple interrupt roots Message-ID: <CANCZdfqeUEFs2PU8N2oHqX1A9RWgafRQXNrdP4xNAoJ8f50_2A@mail.gmail.com> In-Reply-To: <CANxpYC9rKD3YFEjueLtjgozBALz-d4DYq9qW53B2Ljyf47=afA@mail.gmail.com> References: <1B971CC2-DD1F-488B-A80B-98EF29256D50.ref@yahoo.com> <1B971CC2-DD1F-488B-A80B-98EF29256D50@yahoo.com> <CANCZdfr2CbqBiAfkrHYz%2B837KXAp=aQsRPXt4imqz8_C_DO2gg@mail.gmail.com> <CANxpYC9rKD3YFEjueLtjgozBALz-d4DYq9qW53B2Ljyf47=afA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--0000000000005008030622f7845b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable If there are any tweaks, we can do those. It will be way easier than the initial push. But if not, that's fine too. Warner On Wed, Sep 25, 2024, 2:28=E2=80=AFPM Ayrton Munoz <a.munoz3327@gmail.com> = wrote: > Warner and mmel just got to the PR before I got a chance to address a > few tiny nits but what got committed is fine with me. Thanks for > double checking Mark! > > > On Sun, Sep 22, 2024 at 2:19=E2=80=AFPM Warner Losh <imp@bsdimp.com> wrot= e: > > > > > > > > On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard <marklmi@yahoo.com> = wrote: > >> > >> From: Warner Losh <imp_at_FreeBSD.org> wrote on > >> Date: Sun, 22 Sep 2024 13:19:21 UTC : > >> > >> > The branch main has been updated by imp: > >> > > >> > URL: > https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a6c613801fb= 9761ff1e2 > >> > > >> > commit 85918beb387f179abc93a6c613801fb9761ff1e2 > >> > Author: Ayrton Munoz <a.munoz3327@gmail.com> > >> > AuthorDate: 2024-07-21 18:10:20 +0000 > >> > Commit: Warner Losh <imp@FreeBSD.org> > >> > CommitDate: 2024-09-22 13:18:34 +0000 > >> > > >> > intrng: Add support for multiple interrupt roots > >> > > >> > Different types of interrupts may require using different exception > >> > vectors so this commit adds support multiple interrupt roots to hand= le > >> > these cases. Archs may opt-in to multiple interrupt roots by definin= g > >> > INTR_ROOT_NUM as the number of roots in their intr.h. Based off > >> > https://reviews.freebsd.org/D40161. > >> > > >> > Signed-off-by: Ayrton Munoz <a.munoz3327@gmail.com> > >> > Co-authored-by: Kyle Evans <kevans@FreeBSD.org> > >> > Co-authored-by: Andrew Turner <andrew@FreeBSD.org> > >> > Reviewed-by: imp,mmel,mhorne > >> > Pull-Request: https://github.com/freebsd/freebsd-src/pull/1363 > >> . . . > >> > +/* > >> > + * Archs may define multiple roots with INTR_ROOT_NUM to support > different kinds > >> > + * of interrupts (e.g. arm64 FIQs which use a different exception > vector than > >> > + * IRQs). > >> > + */ > >> > +#if !defined(INTR_ROOT_NUM) > >> > +#define INTR_ROOT_NUM 1 > >> > +#endif > >> > + > >> > >> . . . > >> > >> When I was reading the: > >> > >> https://github.com/freebsd/freebsd-src/pull/1363 > >> > >> conversation I saw: > >> > >> -#define INTR_ROOT_NUM 2 > >> +#define INTR_ROOT_COUNT 2 > >> > >> and related discussion with 2 thumbs up, including one by ayrtonm. > >> > >> A similar point goes for: > >> > >> -void *arg, uint32_t rootnum) > >> +void *arg, uint32_t roottype) > >> > >> with another ayrtonm thumbs up at the end. (I've not checked > >> if there are more distinctions.) > >> > >> Such leaves me wondering if what was committed was actually > >> the final intended code: Is it? > > > > > > I thought it was... If we need a fllowup, i can do that... > > > > Warner > > > >> =3D=3D=3D > >> Mark Millard > >> marklmi at yahoo.com > >> > --0000000000005008030622f7845b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"auto">If there are any tweaks, we can do those. It will be way = easier than the initial push. But if not, that's=C2=A0fine too.<div dir= =3D"auto"><br></div><div dir=3D"auto">Warner=C2=A0</div></div><br><div clas= s=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Sep 25, 202= 4, 2:28=E2=80=AFPM Ayrton Munoz <<a href=3D"mailto:a.munoz3327@gmail.com= ">a.munoz3327@gmail.com</a>> wrote:<br></div><blockquote class=3D"gmail_= quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1= ex">Warner and mmel just got to the PR before I got a chance to address a<b= r> few tiny nits but what got committed is fine with me. Thanks for<br> double checking Mark!<br> <br> <br> On Sun, Sep 22, 2024 at 2:19=E2=80=AFPM Warner Losh <<a href=3D"mailto:i= mp@bsdimp.com" target=3D"_blank" rel=3D"noreferrer">imp@bsdimp.com</a>> = wrote:<br> ><br> ><br> ><br> > On Sun, Sep 22, 2024, 7:01=E2=80=AFPM Mark Millard <<a href=3D"mail= to:marklmi@yahoo.com" target=3D"_blank" rel=3D"noreferrer">marklmi@yahoo.co= m</a>> wrote:<br> >><br> >> From: Warner Losh <imp_at_FreeBSD.org> wrote on<br> >> Date: Sun, 22 Sep 2024 13:19:21 UTC :<br> >><br> >> > The branch main has been updated by imp:<br> >> ><br> >> > URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D859= 18beb387f179abc93a6c613801fb9761ff1e2" rel=3D"noreferrer noreferrer" target= =3D"_blank">https://cgit.FreeBSD.org/src/commit/?id=3D85918beb387f179abc93a= 6c613801fb9761ff1e2</a><br> >> ><br> >> > commit 85918beb387f179abc93a6c613801fb9761ff1e2<br> >> > Author: Ayrton Munoz <<a href=3D"mailto:a.munoz3327@gmail.= com" target=3D"_blank" rel=3D"noreferrer">a.munoz3327@gmail.com</a>><br> >> > AuthorDate: 2024-07-21 18:10:20 +0000<br> >> > Commit: Warner Losh <imp@FreeBSD.org><br> >> > CommitDate: 2024-09-22 13:18:34 +0000<br> >> ><br> >> > intrng: Add support for multiple interrupt roots<br> >> ><br> >> > Different types of interrupts may require using different exc= eption<br> >> > vectors so this commit adds support multiple interrupt roots = to handle<br> >> > these cases. Archs may opt-in to multiple interrupt roots by = defining<br> >> > INTR_ROOT_NUM as the number of roots in their intr.h. Based o= ff<br> >> > <a href=3D"https://reviews.freebsd.org/D40161" rel=3D"norefer= rer noreferrer" target=3D"_blank">https://reviews.freebsd.org/D40161</a>.<b= r> >> ><br> >> > Signed-off-by: Ayrton Munoz <<a href=3D"mailto:a.munoz3327= @gmail.com" target=3D"_blank" rel=3D"noreferrer">a.munoz3327@gmail.com</a>&= gt;<br> >> > Co-authored-by: Kyle Evans <kevans@FreeBSD.org><br> >> > Co-authored-by: Andrew Turner <andrew@FreeBSD.org><br> >> > Reviewed-by: imp,mmel,mhorne<br> >> > Pull-Request: <a href=3D"https://github.com/freebsd/freebsd-s= rc/pull/1363" rel=3D"noreferrer noreferrer" target=3D"_blank">https://githu= b.com/freebsd/freebsd-src/pull/1363</a><br> >> . . .<br> >> > +/*<br> >> > + * Archs may define multiple roots with INTR_ROOT_NUM to sup= port different kinds<br> >> > + * of interrupts (e.g. arm64 FIQs which use a different exce= ption vector than<br> >> > + * IRQs).<br> >> > + */<br> >> > +#if !defined(INTR_ROOT_NUM)<br> >> > +#define INTR_ROOT_NUM 1<br> >> > +#endif<br> >> > +<br> >><br> >> . . .<br> >><br> >> When I was reading the:<br> >><br> >> <a href=3D"https://github.com/freebsd/freebsd-src/pull/1363" rel= =3D"noreferrer noreferrer" target=3D"_blank">https://github.com/freebsd/fre= ebsd-src/pull/1363</a><br> >><br> >> conversation I saw:<br> >><br> >> -#define INTR_ROOT_NUM 2<br> >> +#define INTR_ROOT_COUNT 2<br> >><br> >> and related discussion with 2 thumbs up, including one by ayrtonm.= <br> >><br> >> A similar point goes for:<br> >><br> >> -void *arg, uint32_t rootnum)<br> >> +void *arg, uint32_t roottype)<br> >><br> >> with another ayrtonm thumbs up at the end. (I've not checked<b= r> >> if there are more distinctions.)<br> >><br> >> Such leaves me wondering if what was committed was actually<br> >> the final intended code: Is it?<br> ><br> ><br> > I thought it was... If we need a fllowup, i can do that...<br> ><br> > Warner<br> ><br> >> =3D=3D=3D<br> >> Mark Millard<br> >> marklmi at <a href=3D"http://yahoo.com" rel=3D"noreferrer noreferr= er" target=3D"_blank">yahoo.com</a><br> >><br> </blockquote></div> --0000000000005008030622f7845b--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqeUEFs2PU8N2oHqX1A9RWgafRQXNrdP4xNAoJ8f50_2A>