Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 30 Oct 2012 12:25:52 +0000 (UTC)
From:      Attilio Rao <attilio@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r242356 - head/sys/kern
Message-ID:  <201210301225.q9UCPqUq088689@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: attilio
Date: Tue Oct 30 12:25:52 2012
New Revision: 242356
URL: http://svn.freebsd.org/changeset/base/242356

Log:
  tdq_lock_pair() already does spinlock_enter() so migration is not
  possible in sched_balance_pair(). Remove redundant sched_pin().
  
  Reviewed by:	marius, jeff

Modified:
  head/sys/kern/sched_ule.c

Modified: head/sys/kern/sched_ule.c
==============================================================================
--- head/sys/kern/sched_ule.c	Tue Oct 30 11:33:47 2012	(r242355)
+++ head/sys/kern/sched_ule.c	Tue Oct 30 12:25:52 2012	(r242356)
@@ -910,10 +910,8 @@ sched_balance_pair(struct tdq *high, str
 		 * reschedule with the new workload.
 		 */
 		cpu = TDQ_ID(low);
-		sched_pin();
 		if (cpu != PCPU_GET(cpuid))
 			ipi_cpu(cpu, IPI_PREEMPT);
-		sched_unpin();
 	}
 	tdq_unlock_pair(high, low);
 	return (moved);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201210301225.q9UCPqUq088689>