From owner-cvs-src@FreeBSD.ORG  Wed Oct 22 12:59:47 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2CC2A16A4B3; Wed, 22 Oct 2003 12:59:47 -0700 (PDT)
Received: from spider.deepcore.dk
	(cpe.atm2-0-56339.0x50c6aa0a.abnxx2.customer.tele.dk [80.198.170.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 80EF343F3F; Wed, 22 Oct 2003 12:59:36 -0700 (PDT)
	(envelope-from sos@spider.deepcore.dk)
Received: from spider.deepcore.dk (localhost [127.0.0.1])
	by spider.deepcore.dk (8.12.10/8.12.10) with ESMTP id h9MJxNiO038156;
	Wed, 22 Oct 2003 21:59:23 +0200 (CEST)
	(envelope-from sos@spider.deepcore.dk)
Received: (from sos@localhost)
	by spider.deepcore.dk (8.12.10/8.12.10/Submit) id h9MJxNAX038155;
	Wed, 22 Oct 2003 21:59:23 +0200 (CEST)
	(envelope-from sos)
From: Soren Schmidt <sos@spider.deepcore.dk>
Message-Id: <200310221959.h9MJxNAX038155@spider.deepcore.dk>
In-Reply-To: <XFMail.20031022150915.jhb@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.ORG>
Date: Wed, 22 Oct 2003 21:59:23 +0200 (CEST)
X-Mailer: ELM [version 2.4ME+ PL99f (25)]
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=ISO-8859-1
X-mail-scanned: by DeepCore Virus & Spam killer v1.3
cc: Dan Strick <strick@covad.net>
cc: src-committers@FreeBSD.ORG
cc: cvs-src@FreeBSD.ORG
cc: Alexander Leidinger <Alexander@Leidinger.net>
cc: cvs-all@FreeBSD.ORG
cc: sos@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/dev/ata ata-dma.c ata-pci.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Oct 2003 19:59:47 -0000

It seems John Baldwin wrote:
> 
> On 22-Oct-2003 Alexander Leidinger wrote:
> > On Wed, 22 Oct 2003 07:43:53 -0700 (PDT)
> > John Baldwin <jhb@freebsd.org> wrote:
> > 
> >>   Modified files:        (Branch: RELENG_4)
> >>     sys/dev/ata          ata-dma.c ata-pci.c 
> >>   Log:
> >>   MFC: Add support for the Intel ICH5 SATA controller in both legacy and
> >>   enhanced mode.
> >>   
> >>   Submitted by:   Dan Strick <strick@covad.net>
> >>   Approved by:    re (murray)
> > 
> > Does this actually work? On -current it doesn't work flawlessly with an
> > Asus P4P800 board. Accessing one SATA disk results in a lot of spurious
> > interrupts, and using a vinum stripe over 2 SATA disks results in a
> > kernel panic in the ata code.

For current you need to update to the latest I've just yesterday fixed 
the DMA problem that occoured on the SiI3112, and the fix might help
on other problems as well. And please loose vinum out of the mix here,
it is not helping to find evt problems.

> Yes.  Current likely needs the equivalent fix to its interrupt routine
> that this patch includes to avoid the spurious interrupts.

If we are talking about the same thing, current does NOT need that patch
and its also bad on releng4, it clears the error bits which are read
later on for errors...

-Søren