From owner-cvs-all Tue Jan 18 13:41:47 2000 Delivered-To: cvs-all@freebsd.org Received: from green.dyndns.org (localhost [127.0.0.1]) by hub.freebsd.org (Postfix) with ESMTP id 8146014CAF; Tue, 18 Jan 2000 13:41:39 -0800 (PST) (envelope-from green@FreeBSD.org) Received: from localhost (green@localhost) by green.dyndns.org (8.9.3/8.9.3) with ESMTP id QAA53489; Tue, 18 Jan 2000 16:41:30 -0500 (EST) (envelope-from green@FreeBSD.org) X-Authentication-Warning: green.dyndns.org: green owned process doing -bs Date: Tue, 18 Jan 2000 16:41:29 -0500 (EST) From: Brian Fundakowski Feldman X-Sender: green@green.dyndns.org To: Kris Kennaway Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/secure/usr.bin/openssl Makefile In-Reply-To: <200001162100.NAA00953@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Sun, 16 Jan 2000, Kris Kennaway wrote: > kris 2000/01/16 13:00:07 PST > > Modified files: > secure/usr.bin/openssl Makefile > Log: > The wrong version of the file was committed previously which explains the > problems seen here. Thanks for your continued work here, but there are still problems. In src/secure/usr.bin/openssl/Makefile, you check for librsaref.a in ${LOCALBASE}/lib, but then use -L${LOCALBASE}/lib -lrsaref. This seems like the wrong thing to do to me. Since you're checking for the existence of that specific file, you should use that file, so the line would be LDADD+= ${LOCALBASE}/lib/librsaref.a Without doing that, there are problems. One is that you assume that ${LOCALBASE} is mounted whenever /usr/bin is, and create the dependency on ${LOCALBASE} for parts of the base system. This is not necessarily a bad thing to me for compiling code which uses rsaref (so linking libcrypto from the base with -L${LOCALBASE}/lib -lrsaref should be fine, IMHO), but the base should be usable in its entirety without ${LOCALBASE}. Another is that it breaks world for me. Why? Well, I want to have OpenSSL in ${LOCALBASE}, at least for now. When -L${LOCALBASE}/lib is added, libraries in that path gain precedence over the standard ones. So, it links with the wrong library and can't find symbols it needs. The solution to this would be: RCS file: /usr2/ncvs/src/secure/usr.bin/openssl/Makefile,v --- Makefile 2000/01/16 21:00:06 1.3 +++ Makefile 2000/01/18 21:26:50 @@ -19,3 +19,3 @@ CFLAGS+= -DRSAref -LDADD+= -L${LOCALBASE}/lib -lrsaref +LDADD+= ${LOCALBASE}/lib/rsaref.a .endif > Revision Changes Path > 1.3 +18 -5 src/secure/usr.bin/openssl/Makefile -- Brian Fundakowski Feldman \ FreeBSD: The Power to Serve! / green@FreeBSD.org `------------------------------' To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message