From owner-svn-src-head@FreeBSD.ORG Tue Jan 27 09:07:25 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2B239ACD; Tue, 27 Jan 2015 09:07:25 +0000 (UTC) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id DD000882; Tue, 27 Jan 2015 09:07:24 +0000 (UTC) Received: from nine.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id DBEFE5F9A; Tue, 27 Jan 2015 09:07:18 +0000 (UTC) Received: by nine.des.no (Postfix, from userid 1001) id 023844C3; Tue, 27 Jan 2015 10:07:15 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Alexey Dokuchaev Subject: Re: svn commit: r277737 - in head: etc/pam.d tools/build/mk References: <201501260850.t0Q8oDna015719@svn.freebsd.org> <86fvax91cy.fsf@nine.des.no> <20150127071937.GB77865@FreeBSD.org> Date: Tue, 27 Jan 2015 10:07:15 +0100 In-Reply-To: <20150127071937.GB77865@FreeBSD.org> (Alexey Dokuchaev's message of "Tue, 27 Jan 2015 07:19:37 +0000") Message-ID: <86iofslhh8.fsf@nine.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers , Garrett Cooper , Garrett Cooper X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 09:07:25 -0000 Alexey Dokuchaev writes: > As someone who writes makefile daily I would agree, but there should be a > reason why it was always done with _foo. One obvious one is that it shows > up front all possible values, including conditional ones, which can also > help not to forget something when backporting changes somewhere else. ;-) Mainly that, yes. And this is the idiom used in ../rc.d. Garrett's version seems to be the preferred idiom when listing source files. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no