From owner-freebsd-bugs@FreeBSD.ORG Tue Aug 15 17:10:25 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC82216A4DA for ; Tue, 15 Aug 2006 17:10:25 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4995443D81 for ; Tue, 15 Aug 2006 17:10:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k7FHAMf3046516 for ; Tue, 15 Aug 2006 17:10:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k7FHAMCC046515; Tue, 15 Aug 2006 17:10:22 GMT (envelope-from gnats) Date: Tue, 15 Aug 2006 17:10:22 GMT Message-Id: <200608151710.k7FHAMCC046515@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: "Andrey V. Elsukov" Cc: Subject: Re: bin/94045: [nullfs] dump(8) seg-fault on nullfs X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: "Andrey V. Elsukov" List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Aug 2006 17:10:25 -0000 The following reply was made to PR bin/94045; it has been noted by GNATS. From: "Andrey V. Elsukov" To: bug-followup@FreeBSD.org, gogo@cs.uni-sb.de, pietro.cerutti@gmail.com Cc: Subject: Re: bin/94045: [nullfs] dump(8) seg-fault on nullfs Date: Tue, 15 Aug 2006 21:07:04 +0400 (MSD) >I think the attached patch fix this problem. Sorry for base64, the patch is simple: Index: main.c =================================================================== RCS file: /ncvs/src/sbin/dump/main.c,v retrieving revision 1.63 diff -u -r1.63 main.c --- main.c 18 Apr 2005 15:08:29 -0000 1.63 +++ main.c 15 Aug 2006 16:42:04 -0000 @@ -312,6 +312,8 @@ dt = fstabsearch(disk); if (dt != NULL) { disk = rawname(dt->fs_spec); + if (disk == NULL) + errx(X_STARTUP, "%s: unknown file system", dt->fs_spec); (void)strncpy(spcl.c_dev, dt->fs_spec, NAMELEN); (void)strncpy(spcl.c_filesys, dt->fs_file, NAMELEN); } else { -- WBR, Andrey V. Elsukov