From owner-svn-src-head@freebsd.org Tue Jun 20 15:53:16 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 76FD4D9BD55 for ; Tue, 20 Jun 2017 15:53:16 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 131CC3FAC for ; Tue, 20 Jun 2017 15:53:15 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-User: 8e234e65-55d0-11e7-8f51-6f1fdf31063e X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 73.78.92.27 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [73.78.92.27]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 8e234e65-55d0-11e7-8f51-6f1fdf31063e; Tue, 20 Jun 2017 15:53:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id v5KFr8Em003706; Tue, 20 Jun 2017 09:53:08 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1497973988.81013.78.camel@freebsd.org> Subject: Re: svn commit: r320146 - head/sys/fs/ext2fs From: Ian Lepore To: Pedro Giffuni , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Tue, 20 Jun 2017 09:53:08 -0600 In-Reply-To: <10f2e743-7b55-4a8d-1479-b5b3de9b4fe2@FreeBSD.org> References: <201706201435.v5KEZJdr075723@repo.freebsd.org> <10f2e743-7b55-4a8d-1479-b5b3de9b4fe2@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Jun 2017 15:53:16 -0000 On Tue, 2017-06-20 at 10:48 -0500, Pedro Giffuni wrote: > ... > > On 20/06/2017 09:35, Pedro F. Giffuni wrote: > > > > Author: pfg > > Date: Tue Jun 20 14:35:19 2017 > > New Revision: 320146 > > URL: https://svnweb.freebsd.org/changeset/base/320146 > > > > Log: > >    Improve grammar concerning "metadata". > >     > >    Remove unnecessary space while here. > > > > Modified: > >    head/sys/fs/ext2fs/ext2fs.h > > > > Modified: head/sys/fs/ext2fs/ext2fs.h > > =================================================================== > > =========== > > --- head/sys/fs/ext2fs/ext2fs.h Tue Jun 20 14:28:51 2017 > > (r320145) > > +++ head/sys/fs/ext2fs/ext2fs.h Tue Jun 20 14:35:19 2017 > > (r320146) > > @@ -316,9 +316,8 @@ struct ext2_gd { > >    uint16_t ext4bgd_csum; /* group descriptor > > checksum */ > >   }; > >    > > - > > -/* EXT2FS metadatas are stored in little-endian byte order. These > > macros > > - * helps reading these metadatas > > +/* EXT2FS metadata is stored in little-endian byte order. These > > macros > > + * helps reading them. > >    */ > >    > For the record: "metadata" is tricky as it can be addressed to > either  > plural or singular, what is wrong the use of "metadatas". > > Pedro. > Metadata can be treated as if singular or plural for purposes of making an associated verb match in number.  That's a different issue from the fact that "metadatas" just isn't a word at all. Speaking of making subject and verb match in number, the verb in the 3rd sentence needs to be "help". -- Ian