From owner-dev-commits-src-main@freebsd.org Tue Feb 9 15:37:49 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E8289542ABF for ; Tue, 9 Feb 2021 15:37:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DZn8Y67cFz59Hm for ; Tue, 9 Feb 2021 15:37:49 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f54.google.com with SMTP id u14so22523056wri.3 for ; Tue, 09 Feb 2021 07:37:49 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=CMzrgTJxYTrUIldxV+YXEi3NZcYR8RfRuSkkHU0HleM=; b=Ex9utGr18vtp3fmRpvM+V9DVdXDuabmL2wxOoZ270Oe8PfJ2zKk5zSofgQX3MFd6/K Sc2P29tky1iieLc/oYQ4WZhO2e7CnFC5CG833Fyu1bq70t5LCNWH2h6O11vsnc0m+18Z NZO6j6QdKnuN7RwEckFO6aGomwmHZDIaDCQR6HGFUH4/wamtrd67En6CF67LTc+2LfH6 fDvZp9a+De+yhbA3ylU7OV97e2eUyzuUMup0QRAEFNZSxQYhZm0PMo/Hfu66UDV2fTn1 RQebhBe9fdyNGkjJa6kfqCCzea5ZtBW/+EERZncCcUiE2n4IFHsBvXtbsW/0x83jr/F7 BVXQ== X-Gm-Message-State: AOAM530nlVPI1J40+G3QAiv23y2w46PIsjF2jqlqJp1YPBpr3ArmQd48 6koe5dyhzEGnFYi9DBbBnJbyvQ== X-Google-Smtp-Source: ABdhPJx/onBcoEW9EnKGbUyBB6edf1fGwvih1l25GCAbzoH9lwsFnUwLHl+T2mNWfp9yj0vYap1Sww== X-Received: by 2002:a05:6000:1547:: with SMTP id 7mr26418879wry.301.1612885068384; Tue, 09 Feb 2021 07:37:48 -0800 (PST) Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id p17sm4156885wmq.18.2021.02.09.07.37.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Feb 2021 07:37:47 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\)) Subject: Re: git: af366d353b84 - main - amd64: implement strlen in assembly From: Jessica Clarke In-Reply-To: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> Date: Tue, 9 Feb 2021 15:37:46 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: 7bit Message-Id: <83E33E2F-F7FE-4385-8F99-0A7235F87C63@freebsd.org> References: <202102081915.118JFXkJ067892@gitrepo.freebsd.org> To: Mateusz Guzik X-Mailer: Apple Mail (2.3608.120.23.2.4) X-Rspamd-Queue-Id: 4DZn8Y67cFz59Hm X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Feb 2021 15:37:50 -0000 Here's your review after reading through it for <5 minutes today: On 8 Feb 2021, at 19:15, Mateusz Guzik wrote: > + leaq (%r11,%r8),%rcx > + notq %r11 > + andq %r11,%rcx > + andq %r9,%rcx > ... > + leaq (%r11,%r8),%rcx > + notq %r11 > + andq %rcx,%r11 These look the wrong way round (but you got it the right way round above). > + andq %r9,%rcx Jess