From owner-svn-src-all@FreeBSD.ORG Mon Oct 21 08:51:22 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DD052BB0; Mon, 21 Oct 2013 08:51:22 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5A36A2608; Mon, 21 Oct 2013 08:51:22 +0000 (UTC) Received: from alph.d.allbsd.org (p4181-ipbf1307funabasi.chiba.ocn.ne.jp [123.225.173.181]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r9L8p3bF092146 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 21 Oct 2013 17:51:13 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.7/8.14.5) with ESMTP id r9L8p236095776; Mon, 21 Oct 2013 17:51:02 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Mon, 21 Oct 2013 17:50:57 +0900 (JST) Message-Id: <20131021.175057.1620369871932250305.hrs@allbsd.org> To: jase@FreeBSD.org Subject: Re: svn commit: r256498 - head/etc/rc.d From: Hiroki Sato In-Reply-To: <52617089.6090708@FreeBSD.org> References: <201310150454.r9F4snOM001275@svn.freebsd.org> <52617089.6090708@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Mon_Oct_21_17_50_57_2013_192)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Mon, 21 Oct 2013 17:51:13 +0900 (JST) X-Spam-Status: No, score=-99.0 required=13.0 tests=CONTENT_TYPE_PRESENT, SPF_SOFTFAIL,USER_IN_WHITELIST,X_CHINESE_RELAY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Oct 2013 08:51:22 -0000 ----Security_Multipart(Mon_Oct_21_17_50_57_2013_192)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Jase Thew wrote in <52617089.6090708@FreeBSD.org>: ja> On 15/10/2013 05:54, Hiroki Sato wrote: ja> > Author: hrs ja> > Date: Tue Oct 15 04:54:49 2013 ja> > New Revision: 256498 ja> > URL: http://svnweb.freebsd.org/changeset/base/256498 ja> > ja> > Log: ja> > - Fix "ifname|addr" syntax support in jail_{jname}_ip. ja> > - Create /var/run/jail_{jname}.id because ezjail-admin depends on it. ja> > ja> > Modified: ja> > head/etc/rc.d/jail ja> > ja> ja> Hi Hiroki, ja> ja> This unfortunately breaks ezjail when the address list doesn't use iface ja> prefix syntax. ja> ja> Given this configuration : ja> ja> export jail_poudriere_ip="192.168.1.184,127.0.1.4,::1" ja> ja> results in the following being generated : ja> ja> ip4.addr += "|192.168.1.184/32"; ja> ip4.addr += "|127.0.1.4/32"; ja> ip6.addr += "|::1/64"; ja> ja> The attach patch corrects the issue by suffixing the iface value with ja> "|" only when it has a value. Thank you for your report. r256835 should fix it (and other issues). Please try it and let me know if it works fine. -- Hiroki ----Security_Multipart(Mon_Oct_21_17_50_57_2013_192)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlJk6vEACgkQTyzT2CeTzy3vaQCgtXHAAm9oMspq6B/y8kYeVYYB COsAoJOI99Mt/A51ZsrwouUqZ3Q1ifAY =5lC0 -----END PGP SIGNATURE----- ----Security_Multipart(Mon_Oct_21_17_50_57_2013_192)----