From owner-cvs-all Mon May 13 6:35:32 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id AE99837B403; Mon, 13 May 2002 06:35:21 -0700 (PDT) Received: by elvis.mu.org (Postfix, from userid 1192) id 7EA6EAE25C; Mon, 13 May 2002 06:35:21 -0700 (PDT) Date: Mon, 13 May 2002 06:35:21 -0700 From: Alfred Perlstein To: Dan Eischen Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libc_r/uthread pthread_private.h uthread_attr_setguardsize.cuthread_init.c uthread_stack.c Message-ID: <20020513133521.GV90188@elvis.mu.org> References: <200205130758.g4D7wFo67279@freefall.freebsd.org> <3CDF9CDB.BF0E65F5@vigrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3CDF9CDB.BF0E65F5@vigrid.com> User-Agent: Mutt/1.3.27i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Dan Eischen [020513 04:55] wrote: > Alfred Perlstein wrote: > > > > alfred 2002/05/13 00:58:15 PDT > > > > Modified files: > > lib/libc_r/uthread pthread_private.h > > uthread_attr_setguardsize.c > > uthread_init.c uthread_stack.c > > Log: > > Don't use PAGE_SIZE in userland, instead use getpagesize(), this is to > > allow running on other arches when the instructions are supported but > > the page size granularity is not. > > This adds namespace pollution to libc_r. Please fix and precede externals > with underscores. You should be able to do 'nm libc_r.so.5 | grep " T "' > and not see anything that isn't preceded with underscores. Ok, will do. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductible donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message