From owner-svn-src-head@FreeBSD.ORG Wed Jul 24 04:06:50 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 428CD9F2; Wed, 24 Jul 2013 04:06:50 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 38C9D2773; Wed, 24 Jul 2013 04:06:49 +0000 (UTC) Received: from alph.d.allbsd.org (p2049-ipbf1102funabasi.chiba.ocn.ne.jp [122.26.101.49]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id r6O46UZq048032 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Jul 2013 13:06:40 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [IPv6:::1]) (authenticated bits=0) by alph.d.allbsd.org (8.14.5/8.14.5) with ESMTP id r6O46SVF062121; Wed, 24 Jul 2013 13:06:29 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Wed, 24 Jul 2013 13:06:20 +0900 (JST) Message-Id: <20130724.130620.474995323688503714.hrs@allbsd.org> To: dim@FreeBSD.org Subject: Re: svn commit: r253504 - head/sbin/route From: Hiroki Sato In-Reply-To: <36E48152-1A64-432D-A32D-75059A56E181@FreeBSD.org> References: <201307201646.r6KGkpM6054344@svn.freebsd.org> <36E48152-1A64-432D-A32D-75059A56E181@FreeBSD.org> X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Multipart/Signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="--Security_Multipart(Wed_Jul_24_13_06_20_2013_456)--" Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Wed, 24 Jul 2013 13:06:40 +0900 (JST) X-Spam-Status: No, score=-90.6 required=13.0 tests=CONTENT_TYPE_PRESENT, DIRECTOCNDYN,DYN_PBL,RCVD_IN_PBL,SPF_SOFTFAIL,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jul 2013 04:06:50 -0000 ----Security_Multipart(Wed_Jul_24_13_06_20_2013_456)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Dimitry Andric wrote in <36E48152-1A64-432D-A32D-75059A56E181@FreeBSD.org>: di> On Jul 20, 2013, at 18:46, Hiroki Sato wrote: di> > Author: hrs di> > Date: Sat Jul 20 16:46:51 2013 di> > New Revision: 253504 di> > URL: http://svnweb.freebsd.org/changeset/base/253504 di> > di> > Log: di> > - Simplify getaddr() and print_getmsg() by using RTAX_* instead of RTA_* di> > as the argument. di> > - Reduce unnecessary loop in print_getmsg(). di> > di> > Modified: di> > head/sbin/route/route.c di> di> Hi, di> di> This breaks /etc/rc.d/defaultroute, since it relies on "route -n get di> -inet default" printing a line with "interface:" in it. Before r253504 di> it prints: di> di> route to: 0.0.0.0 di> destination: 0.0.0.0 di> mask: 56.18.1.0 di> gateway: router.example.com di> fib: 0 di> interface: em0 di> flags: di> recvpipe sendpipe ssthresh rtt,msec mtu weight expire di> 0 0 0 0 1500 1 0 di> di> (note also the mask seems to be busted, and even though -n is given, the di> hostname of the gateway is printed, but this is another issue) di> di> At r253504 it gives: di> di> route to: 0.0.0.0 di> destination: 0.0.0.0 di> mask: 56.18.1.0 di> gateway: router.example.com di> fib: 0 di> flags: di> recvpipe sendpipe ssthresh rtt,msec mtu weight expire di> 0 0 0 0 1500 1 0 di> di> So for some reason, the interface: line is gone.. Should be fixed in r253589. Sorry for the breakage. -- Hiroki ----Security_Multipart(Wed_Jul_24_13_06_20_2013_456)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (FreeBSD) iEYEABECAAYFAlHvUrwACgkQTyzT2CeTzy3gwQCgxvuFVfYCWBcgBdTzAn+TCGPd VcgAoJ2Rx+OLSwmpYC9OCUNBn26O5cMo =7oXP -----END PGP SIGNATURE----- ----Security_Multipart(Wed_Jul_24_13_06_20_2013_456)----