From owner-freebsd-net@FreeBSD.ORG Sun Sep 21 23:39:28 2008 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 24BC41065673; Sun, 21 Sep 2008 23:39:28 +0000 (UTC) (envelope-from cmb@pfsense.org) Received: from mxsf03.insightbb.com (mxsf03.insightbb.com [74.128.0.64]) by mx1.freebsd.org (Postfix) with ESMTP id B126B8FC16; Sun, 21 Sep 2008 23:39:25 +0000 (UTC) (envelope-from cmb@pfsense.org) X-IronPort-AV: E=Sophos;i="4.32,443,1217822400"; d="scan'208";a="508520129" Received: from unknown (HELO asav02.insightbb.com) ([172.31.249.124]) by mxsf03.insightbb.com with ESMTP; 21 Sep 2008 19:11:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Aj8BACZx1khgHCYZ/2dsb2JhbAAIrxWFFIFm X-IronPort-AV: E=Sophos;i="4.32,443,1217822400"; d="scan'208";a="288572621" Received: from 96-28-38-25.dhcp.insightbb.com (HELO [10.0.64.34]) ([96.28.38.25]) by asav02.insightbb.com with ESMTP; 21 Sep 2008 19:11:03 -0400 Message-ID: <48D6D489.5070506@pfsense.org> Date: Sun, 21 Sep 2008 19:11:05 -0400 From: Chris Buechler User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: "Bruce M. Simpson" References: <200809212103.m8LL3v61012961@freefall.freebsd.org> <48D6C6CE.3060404@FreeBSD.org> In-Reply-To: <48D6C6CE.3060404@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-net@FreeBSD.org, remko@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/127528: [icmp]: icmp socket receives icmp replies not owned by the process. X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 21 Sep 2008 23:39:28 -0000 Bruce M. Simpson wrote: > remko@FreeBSD.org wrote: >> Old Synopsis: icmp socket receives icmp replies not owned by the >> process. >> New Synopsis: [icmp]: icmp socket receives icmp replies not owned by >> the process. >> > > This PR is bogus because: > ICMP has no concept of datagrams being "owned" by a process. There is > no field in the ICMP protocol which differentiates ICMP "sessions" on > a per-process basis, and this is because ICMP has no concept of > "sessions" -- ICMP messages are directed at IP endpoints. ICMP echo and echo replies do have "sessions" of sorts, at least unique identifying fields - identifier and sequence number. This was opened by a pfSense maintainer because it's a change in behavior from 6.x releases where this was never an issue, and is something we feel is a regression. Ideally you don't want to be pinging the same host from two different processes, but it's difficult to avoid in some circumstances and it's something that always worked fine prior to FreeBSD 7.0. Thanks, Chris