Date: Wed, 21 Apr 2021 15:21:48 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 254343] 13.0-RC2: adding a vtnet (VirtIO network) interface to bridge fails Message-ID: <bug-254343-227-1ruxtpdv5O@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-254343-227@https.bugs.freebsd.org/bugzilla/> References: <bug-254343-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D254343 Aleksandr Fedorov <afedorov@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |afedorov@FreeBSD.org, | |bryanv@FreeBSD.org, | |grehan@FreeBSD.org, | |kevans@freebsd.org Component|misc |kern --- Comment #4 from Aleksandr Fedorov <afedorov@FreeBSD.org> --- I think this is regression in if_vtnet(4). 12-STABLE https://github.com/freebsd/freebsd-src/blob/stable/12/sys/dev/virtio/networ= k/if_vtnet.c#L1103 : if ((ifp->if_flags ^ sc->vtnet_if_flags) & (IFF_PROMISC | IFF_ALLMULTI)) { if (sc->vtnet_flags & VTNET_FLAG_CTRL_RX) vtnet_rx_filter(sc); else { ifp->if_flags |=3D IFF_PROMISC; if ((ifp->if_flags ^ sc->vtnet_if_flags) & IFF_ALLMULTI) error =3D ENOTSUP; } } RELENG 13.0 https://github.com/freebsd/freebsd-src/blob/releng/13.0/sys/dev/virtio/netw= ork/if_vtnet.c#L1297 : if ((ifp->if_flags ^ sc->vtnet_if_flags) & (IFF_PROMISC | IFF_ALLMULTI)) { if ((sc->vtnet_flags & VTNET_FLAG_CTRL_RX) =3D=3D 0) return (ENOTSUP); vtnet_rx_filter(sc); } Therefore, if the hypervisor does not confirm support for VTNET_FLAG_CTRL_R= X, the latest driver version cannot enable PROMISC mode. For example, bhyve doesn't support VTNET_FLAG_CTRL_RX. Technically, if the hypervisor doesn't support the VTNET_FLAG_CTRL_RX, then= the interface is always in PROMISC mode. I see no reason to prohibit switching the interface to PROMISC mode if VTNET_FLAG_CTRL_RX is not supported by the hypervisor. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-254343-227-1ruxtpdv5O>