From owner-svn-src-head@freebsd.org Sun Nov 5 22:31:58 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4B580E53E3B; Sun, 5 Nov 2017 22:31:58 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 174E76F5D2; Sun, 5 Nov 2017 22:31:58 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 42EE77A06; Sun, 5 Nov 2017 22:31:57 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 3A4EE5802; Sun, 5 Nov 2017 22:31:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id pmNaQV2hB0Ki; Sun, 5 Nov 2017 22:31:53 +0000 (UTC) Subject: Re: svn commit: r325368 - head/sys/kern DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 8836D57FC To: Ian Lepore , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" References: <201711031921.vA3JLakQ010001@repo.freebsd.org> <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org> <1509908174.99235.60.camel@freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: Date: Sun, 5 Nov 2017 14:31:37 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1509908174.99235.60.camel@freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 22:31:58 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc Content-Type: multipart/mixed; boundary="1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa"; protected-headers="v1" From: Bryan Drewery To: Ian Lepore , Ed Maste Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: Subject: Re: svn commit: r325368 - head/sys/kern References: <201711031921.vA3JLakQ010001@repo.freebsd.org> <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org> <1509908174.99235.60.camel@freebsd.org> In-Reply-To: <1509908174.99235.60.camel@freebsd.org> --1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/5/2017 10:56 AM, Ian Lepore wrote: > On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: >> "On 3 November 2017 at 16:42, Bryan Drewery >> wrote: >>> >>> >>>> >>>> =C2=A0 Differential Revision:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0D12= 929 >>> Apparently this format closes the review now? I thought we needed a >>> full >>> URL? >> Interesting, Phabricator reports "We found a "Differential Revision" >> field with value "12929" in the commit message, and the domain on the >> URI matches this install, so we linked this commit to D12929."=C2=A0=C2= =A0It >> looks like Phabricator was changed to accept only the D##### tag, but >> not the "Explain why" text. >> >=20 > I like having the full URL, and would like that to remain the standard.= > =C2=A0It's very useful when you're perusing svn logs and you can just c= lick > on the url to get to the phab material cited in the commit. Yeah despite my "\o/", I ended up sticking to the URL format myself too. >=20 > If people want the convenience of typing the shorter info, could we > make the svn commit hooks expand it to an url? >=20 > -- Ian >=20 --=20 Regards, Bryan Drewery --1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa-- --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/5FJAAoJEDXXcbtuRpfPjUsIAMtN6sew8eA4bZFCJ1KQU1UM qRjI4Z6mPZjZ4Jt6etFekxYf2JSjyx2yO1mYDJgmhNjVztiJ4ofqNJNMUbO5FZ43 VJ/yb6lq0TRG4zJS381WvM+H6QeSMYcM9LCUe/2DDvVLs7vd7hQ7s9pC+eTu4uPw Clt6g3H7raSwS64vYox2LmKhJdYWiIg7OPdT1akOKemuC7riS7kPggwfa8U4V1DG oh7tNMt0pfxAl6YPhWs5/6APtv7cB3SxPabfdNiW4fpxcZIdrfatesJ237iUtTfk 14Us7lTtNqU2dCJlvXNE4MhmrBZOPN0yUr74RxGKzDkbd2FaS0mmvwTel5tqpLY= =GNr+ -----END PGP SIGNATURE----- --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc--