From owner-svn-src-stable@freebsd.org Wed Aug 15 18:18:13 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B43F8106B132; Wed, 15 Aug 2018 18:18:13 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 644A87253F; Wed, 15 Aug 2018 18:18:13 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 00FC316673; Wed, 15 Aug 2018 18:18:12 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lf1-f48.google.com with SMTP id n96-v6so1532562lfi.1; Wed, 15 Aug 2018 11:18:12 -0700 (PDT) X-Gm-Message-State: AOUpUlHirp9HA18wPIRRxvJWYdgS/N2E5N+Yx94CS3zZm4kW6VPBBEFw BBvPiwMzUTcziRgMMWvF68PXcpn8JU1VWEPn7gI= X-Google-Smtp-Source: AA+uWPwvAJp1gdp1wEZS5RfyK8iY30O80onWy50Gz664qcQ6/hT2zPoIz3kKWjX/vSabKvcr90OcnVpSHB5a7REXUBg= X-Received: by 2002:a19:26d2:: with SMTP id m201-v6mr16642582lfm.43.1534357091599; Wed, 15 Aug 2018 11:18:11 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Wed, 15 Aug 2018 11:17:50 -0700 (PDT) In-Reply-To: <201808151743.w7FHhBT9048918@pdx.rh.CN85.dnsmgr.net> References: <201808151743.w7FHhBT9048918@pdx.rh.CN85.dnsmgr.net> From: Kyle Evans Date: Wed, 15 Aug 2018 13:17:50 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337826 - stable/11/bin/ls To: "Rodney W. Grimes" Cc: Adam Weinberger , Kyle Evans , svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Maste , svn-src-stable-11@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 18:18:13 -0000 On Wed, Aug 15, 2018 at 12:43 PM, Rodney W. Grimes wrote: > > From the Linux man page at: http://man7.org/linux/man-pages/man1/ls.1.html > > Using color to distinguish file types is disabled both by default and > with --color=never. With --color=auto, ls emits color codes only > when standard output is connected to a terminal. The LS_COLORS > environment variable can change the settings. Use the dircolors > command to set it. > > Um, so by default we should not be doing any colour... and we are... > I don't recall making any argument that we're trying to match GNU ls(1) behavior. Furthermore, again, we aren't doing any color by default- only when the COLORTERM environment variable is set. ls(1) on FreeBSD historically honors -an- environment variable for enabling color. This environment variable is CLICOLOR. This commit switched the environment variable honored to the more-standard COLORTERM that is honored in other software and set by terminals that are generally expected to be used with color. I'm writing an UPDATING entry for this now to notify these users that they should remove COLORTERM from their environment if they do not, in fact, want a colored terminal.