From owner-cvs-all  Mon Dec 16 17: 8:35 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 90FCB37B401; Mon, 16 Dec 2002 17:08:34 -0800 (PST)
Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 3A63343EB2; Mon, 16 Dec 2002 17:08:34 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: from apollo.backplane.com (localhost [127.0.0.1])
	by apollo.backplane.com (8.12.5/8.12.5) with ESMTP id gBH18VOM082435;
	Mon, 16 Dec 2002 17:08:31 -0800 (PST)
	(envelope-from dillon@apollo.backplane.com)
Received: (from dillon@localhost)
	by apollo.backplane.com (8.12.5/8.12.5/Submit) id gBH18V4r082434;
	Mon, 16 Dec 2002 17:08:31 -0800 (PST)
	(envelope-from dillon)
Date: Mon, 16 Dec 2002 17:08:31 -0800 (PST)
From: Matthew Dillon <dillon@apollo.backplane.com>
Message-Id: <200212170108.gBH18V4r082434@apollo.backplane.com>
To: Julian Elischer <julian@elischer.org>
Cc: Nate Lawson <nate@root.org>,
	Julian Elischer <julian@FreeBSD.ORG>, cvs-all@FreeBSD.ORG,
	cvs-committers@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/i386/i386 dump_machdep.c
References:  <Pine.BSF.4.21.0212161621470.11938-100000@InterJet.elischer.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG


:
:
:
:On Mon, 16 Dec 2002, Matthew Dillon wrote:
:
:>     Hmm.  Wouldn't this be easier if the test were done after
:>     calculating dumplo?  e.g.
:> 
:> :>  	dumplo = di->mediaoffset + di->mediasize - Maxmem * (off_t)PAGE_SIZE;
:> :>  	dumplo -= sizeof kdh * 2;
:> 
:
:no because then you'd have to check fopr dumplo being -ve
:and I'm of the opinion that blocknumbers should always be unsigned (*)
:so if this were ever "corrected" to be unsigned, you'd 
:have to check for an overflow which is difficult.
:
:(*) there are many bugs showing up at the moment as disks start to
:get NBLK > 2^31 blocks on them that wouldn't happen if they were
:unsigned..
:
:I have 3 such devices each with >1TB.
:If you want to see things explode, just try run sysinstall on them.

    Isn't it using off_t there?  64 bit offsets?

					-Matt
					Matthew Dillon 
					<dillon@backplane.com>

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message