From owner-freebsd-xfce@freebsd.org Sat Jan 9 21:29:20 2021 Return-Path: Delivered-To: freebsd-xfce@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 235254E3A85 for ; Sat, 9 Jan 2021 21:29:20 +0000 (UTC) (envelope-from ml@netfence.it) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4DCtQR6Ynsz4Wvw for ; Sat, 9 Jan 2021 21:29:19 +0000 (UTC) (envelope-from ml@netfence.it) Received: by mailman.nyi.freebsd.org (Postfix) id E13334E3A84; Sat, 9 Jan 2021 21:29:19 +0000 (UTC) Delivered-To: xfce@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E0F464E392F for ; Sat, 9 Jan 2021 21:29:19 +0000 (UTC) (envelope-from ml@netfence.it) Received: from soth.netfence.it (mailserver.netfence.it [78.134.96.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mailserver.netfence.it", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4DCtQQ36vBz4WWP for ; Sat, 9 Jan 2021 21:29:17 +0000 (UTC) (envelope-from ml@netfence.it) Received: from alamar.ventu (alamar.local.netfence.it [10.1.2.18]) (authenticated bits=0) by soth.netfence.it (8.16.1/8.16.1) with ESMTPSA id 109LT9KA087288 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NO); Sat, 9 Jan 2021 22:29:09 +0100 (CET) (envelope-from ml@netfence.it) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netfence.it; s=202005; t=1610227749; bh=agltpZ4aJw8qTFzaslYnr9A6qP7vsE/gdvUTjaXUsUE=; h=Subject:From:To:References:Date:In-Reply-To; b=Nrb4P0EQRzWZEfCpHKG3ktu1d7Q+A7TftJOmz7SBK1q2gBkQaD/PO+wy24ELTC9yT OGnIk5+2tDlzmoaTulqu2ZQ/hQ805dHJgPIWEzo59e0kAMPOxBUPztxtN7qMJCcPH6 Bj+1FX0sTMwh9vCvSLPJ17wYQ9j5wbXiL7xHUOwE= X-Authentication-Warning: soth.netfence.it: Host alamar.local.netfence.it [10.1.2.18] claimed to be alamar.ventu Subject: Re: XFCE upgraded to 4.16 From: Andrea Venturoli To: Guido Falsi , xfce@freebsd.org References: <46a21428-a640-f895-0f3b-f44c09497bf5@madpilot.net> <747ecac6-6d60-6143-1ae1-47801299b59b@netfence.it> <1502a321-02c0-13e9-16b3-6f11da9de3af@madpilot.net> <47ede65d-817a-8d80-a582-660d43ac6ac3@andreaventuroli.it> <45c74d5a-909b-8905-6673-b340e1d976b4@netfence.it> <989cf919-245c-61f9-3091-b0933849093b@netfence.it> <2b8631d8-479b-15ee-1efd-cc4bffd14710@madpilot.net> <838b577f-eb40-2776-19d4-2fb5f71611b3@netfence.it> <3655b4f7-0012-424b-7aa6-1d85fa2e9021@madpilot.net> Message-ID: <5ac5e637-8c47-0a0d-f8dd-d38dcecd4ed0@netfence.it> Date: Sat, 9 Jan 2021 22:29:09 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Rspamd-Queue-Id: 4DCtQQ36vBz4WWP X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none (invalid DKIM record) header.d=netfence.it header.s=202005 header.b=Nrb4P0EQ; dmarc=pass (policy=none) header.from=netfence.it; spf=pass (mx1.freebsd.org: domain of ml@netfence.it designates 78.134.96.152 as permitted sender) smtp.mailfrom=ml@netfence.it X-Spamd-Result: default: False [-2.20 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:78.134.96.152]; HAS_ATTACHMENT(0.00)[]; HAS_XAW(0.00)[]; DKIM_TRACE(0.00)[netfence.it:~]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[netfence.it,none]; NEURAL_HAM_SHORT(-1.00)[-0.999]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[78.134.96.152:from]; ASN(0.00)[asn:35612, ipnet:78.134.0.0/17, country:IT]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/mixed,text/plain,text/x-csrc]; MIME_BAD_ATTACHMENT(1.60)[c]; SPAMHAUS_ZRD(0.00)[78.134.96.152:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_DKIM_PERMFAIL(0.00)[netfence.it:s=202005]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[xfce] Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: freebsd-xfce@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: XFCE for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Jan 2021 21:29:20 -0000 On 1/9/21 11:59 AM, Andrea Venturoli wrote: > Right now I reached an usable config on my desktop, but I will try and > get suck a backtrace and I'll come back if I succeed. Here it is: > (gdb) bt > #0 0x0000000800e95287 in g_filename_from_uri () at /usr/local/lib/libglib-2.0.so.0 > #1 0x00000000002103a7 in install_theme (widget=0x80361c3f0, uris=0x80463bf98, builder=0x802d504e0) at main.c:881 > #2 0x000000000020f949 in appearance_settings_install_theme_cb (widget=0x803631180, builder=0x802d504e0) at main.c:1000 > #3 0x0000000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0 > #4 0x0000000800dc8488 in g_signal_emit_valist () at /usr/local/lib/libgobject-2.0.so.0 > #5 0x0000000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0 > #6 0x00000008008ab72e in () at /usr/local/lib/libgtk-3.so.0 > #7 0x0000000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0 > #8 0x0000000800dc8488 in g_signal_emit_valist () at /usr/local/lib/libgobject-2.0.so.0 > #9 0x0000000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0 > #10 0x00000008008abd36 in () at /usr/local/lib/libgtk-3.so.0 > #11 0x0000000800b8dc18 in () at /usr/local/lib/libgtk-3.so.0 > #12 0x0000000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0 > #13 0x0000000800dc8488 in g_signal_emit_valist () at /usr/local/lib/libgobject-2.0.so.0 > #14 0x0000000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0 > #15 0x00000008009817f1 in () at /usr/local/lib/libgtk-3.so.0 > #16 0x0000000800db588c in g_cclosure_marshal_VOID__BOXEDv () at /usr/local/lib/libgobject-2.0.so.0 > #17 0x0000000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0 > #18 0x0000000800dc8488 in g_signal_emit_valist () at /usr/local/lib/libgobject-2.0.so.0 > #19 0x0000000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0 > #20 0x000000080097f69e in () at /usr/local/lib/libgtk-3.so.0 > #21 0x0000000800983395 in () at /usr/local/lib/libgtk-3.so.0 > #22 0x000000080094341c in gtk_event_controller_handle_event () at /usr/local/lib/libgtk-3.so.0 > #23 0x0000000800b35d9c in () at /usr/local/lib/libgtk-3.so.0 > #24 0x0000000800b882c1 in () at /usr/local/lib/libgtk-3.so.0 > #25 0x0000000800db2486 in () at /usr/local/lib/libgobject-2.0.so.0 > #26 0x0000000800dc8488 in g_signal_emit_valist () at /usr/local/lib/libgobject-2.0.so.0 > #27 0x0000000800dc8ee6 in g_signal_emit () at /usr/local/lib/libgobject-2.0.so.0 > #28 0x0000000800b35ad9 in () at /usr/local/lib/libgtk-3.so.0 > #29 0x00000008009d1c5f in gtk_propagate_event () at /usr/local/lib/libgtk-3.so.0 > #30 0x00000008009d17ef in gtk_main_do_event () at /usr/local/lib/libgtk-3.so.0 > #31 0x00000008002e43a1 in () at /usr/local/lib/libgdk-3.so.0 > #32 0x0000000800319877 in () at /usr/local/lib/libgdk-3.so.0 > #33 0x0000000800eb9a7e in g_main_context_dispatch () at /usr/local/lib/libglib-2.0.so.0 > #34 0x0000000800eb9e24 in () at /usr/local/lib/libglib-2.0.so.0 > #35 0x0000000800eba17a in g_main_loop_run () at /usr/local/lib/libglib-2.0.so.0 > #36 0x00000008009d111b in gtk_main () at /usr/local/lib/libgtk-3.so.0 > #37 0x000000000020cb2d in main (argc=1, argv=0x7fffffffe660) at main.c:1307 In frame #1 (install_theme) we have: > static void > install_theme (GtkWidget *widget, gchar **uris, GtkBuilder *builder) > { > ... > for (i = 0; uris[i] != NULL; i++) > { > ... However in the caller (at frame #2, i.e. appearance_settings_install_theme_cb): > gchar **uris; > GtkFileChooser *chooser = GTK_FILE_CHOOSER (dialog); > > uris = g_new0 (gchar *, 1); > filename = gtk_file_chooser_get_filename (chooser); > uris[0] = g_filename_to_uri (filename, NULL, NULL); > install_theme (window, uris, builder); So what I think happens is that the loop processes uri[0], which holds the filename, but fails to find a NULL after it, since it was never allocated. Guess it should read: uris = g_new0 (gchar *, 2); Of course this should be fixed upstream, but in the meantime I'm attaching a patch that solves for me. bye av.