From owner-svn-src-head@FreeBSD.ORG Mon Jul 25 19:29:16 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 292EF106564A; Mon, 25 Jul 2011 19:29:16 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-gw0-f54.google.com (mail-gw0-f54.google.com [74.125.83.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7815D8FC22; Mon, 25 Jul 2011 19:29:15 +0000 (UTC) Received: by gwb15 with SMTP id 15so3399003gwb.13 for ; Mon, 25 Jul 2011 12:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=P/p+1Hnu7obJmzr0VAbTWU5AMKNRcjeJFJUssc5EaHc=; b=k8RqDuTMVcB41AF2+9K4GgW/8NrqsYtUAEELei1GZSnufSj0FIMFXQJWrNC3NKazbl rl3maj5xeSOdt5yTAm0mz77E1BoOaD9YDo54uGA9o41aD+oxy69zzxS/wjIq4SskHGMj PVi+IASHL2LTsMimGsyu6HAUebQmWFIaxvNAE= MIME-Version: 1.0 Received: by 10.236.9.100 with SMTP id 64mr6452817yhs.339.1311622154832; Mon, 25 Jul 2011 12:29:14 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.108.129 with HTTP; Mon, 25 Jul 2011 12:29:14 -0700 (PDT) In-Reply-To: <4E2DBCBF.2030402@freebsd.org> References: <201107191241.p6JCfvqw072816@svn.freebsd.org> <4E2C9012.602@freebsd.org> <4E2DB8AC.3000703@FreeBSD.org> <4E2DBCBF.2030402@freebsd.org> Date: Mon, 25 Jul 2011 21:29:14 +0200 X-Google-Sender-Auth: GhDILY6GDjb4uWHlMs1jaQ9Vra8 Message-ID: From: Attilio Rao To: Nathan Whitehorn Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, FreeBSD Release Engineering Team , Andreas Tobler Subject: Re: svn commit: r224216 - in head/sys: ia64/ia64 mips/mips powerpc/aim sparc64/sparc64 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Jul 2011 19:29:16 -0000 Guys, I'm a bit out of that for a couple of days, flying to another continent, I'm not entirely sure the patch is right because I think we need an unified approach for specifying a 32-bits value, but you can check-in as a showstopper for the moment, I will make a better one in a couple of days. Attilio 2011/7/25 Nathan Whitehorn : > On 07/25/11 13:40, Andreas Tobler wrote: >> >> On 24.07.11 23:35, Nathan Whitehorn wrote: >>> >>> On 07/19/11 07:41, Attilio Rao wrote: >>>> >>>> Author: attilio >>>> Date: Tue Jul 19 12:41:57 2011 >>>> New Revision: 224216 >>>> URL: http://svn.freebsd.org/changeset/base/224216 >>>> >>>> Log: >>>> On 64 bit architectures size_t is 8 bytes, thus it should use an 8 bytes >>>> storage. >>>> Fix the sintrcnt/sintrnames specification. >>>> >>>> No MFC is previewed for this patch. >>>> >>> >>> These also need to be .long on 32-bit PowerPC, otherwise this change >>> triggers kernel panics and faults in sysctl. Please change it as quickly >>> as possible. >> >> Like the below? >> >> I'll test and I could commit if ok. (Build and approval) >> >> Gruss, >> Andreas >> >> Index: locore32.S >> =================================================================== >> --- locore32.S (revision 224326) >> +++ locore32.S (working copy) >> @@ -91,13 +91,13 @@ >> GLOBAL(intrnames) >> .space INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >> GLOBAL(sintrnames) >> - .word INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >> + .long INTRCNT_COUNT * (MAXCOMLEN + 1) * 2 >> >> .align 4 >> GLOBAL(intrcnt) >> .space INTRCNT_COUNT * 4 * 2 >> GLOBAL(sintrcnt) >> - .word INTRCNT_COUNT * 4 * 2 >> + .long INTRCNT_COUNT * 4 * 2 >> >> .text >> .globl btext > > Exactly like that. > -Nathan > -- Peace can only be achieved by understanding - A. Einstein