From owner-freebsd-transport@freebsd.org Tue Apr 21 23:51:26 2020 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DC7322BE59F for ; Tue, 21 Apr 2020 23:51:26 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 496L1n6vy3z4P1M for ; Tue, 21 Apr 2020 23:51:25 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: by mailman.nyi.freebsd.org (Postfix) id ED2F32BE59E; Tue, 21 Apr 2020 23:51:25 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id ECE902BE59D for ; Tue, 21 Apr 2020 23:51:25 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2076.outbound.protection.outlook.com [40.107.243.76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 496L1m3CvPz4P1J; Tue, 21 Apr 2020 23:51:24 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Wb2bsDvUrooBaPiIK1Qy0Rit2N0CtZiJ6waS8yjxrh/qilFhCi8FwZU9do7sjEE8pD1ACzjSBiGS0NNAIWiNC1QC/iDQD55uQeGyFk7jmEFSMth57tvsSbi4uCkLeMyqtLNRPI0aUhINpm7SPyv4tf4p3Ru9Y90+wkUQVWYgZy51nr9PRAOPC5lr1kdDd33gXZA6sLek7U+BZzWSisp/AiBfc55Vn8PHhCPFM+Bx5NTFJTYaOu7H4wL1nJEY4tNvyYbYQmyeI4zLY3HGs6ZO7wNZAJ5kmmMJIG8XLxeVBqkB0taacrdbs14ZhXk1+x3NnyT+7zWgN4WDE86zfyIcIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXyk1jdN0ZzsCADmh3wDqbwhWymlZylx8uyiKU6dCM4=; b=iHPacz70SJ3OWnneMN7j4au8LSCmq33dOoevilieoOfxUkKKSnRL68k52KDG9hmajUTF9FBvJea4L2CM6kmazplGmo9x02y/W6zeofZtYdn74yXS/qVVWBg3ZyS4YLdpk6Buvoc2BAWFTKp0qhqPcqcGAcST8gP1p5FNw7THT7kRSAhmgcwllmWLBaAMWX0EM/9ei5iNQixz/A9oOesX3n0QK0Uov57MH9CmL9+FUf2s00vbPtt+W4N5CqAH6LnRP7Kk+hpm+D1XEzpFr7999hxUJfTbuzjHU4d/DopHL7+4+0ueoVPJy7VU0wmxy0lz6xJWf3s8XXd/C+wCo51JvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.onmicrosoft.com; s=selector1-netapp-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OXyk1jdN0ZzsCADmh3wDqbwhWymlZylx8uyiKU6dCM4=; b=Eiztrsz6G+jHp9XZozLBVCRzzKWzXMeD9Xx8Ln5msJBvpAM37P8hA9GmaKj6JzLmcQtS/VkO+DhbyuSl4MSniiB1n0ErIvZ6kfsqZ4/EQTJ+jwFqbacHyYWaMHlBvALfxCfrsOu5GVBho9GRKSWoBeJJu2l8Wu1oj8y/sdUtJrc= Received: from SN4PR0601MB3728.namprd06.prod.outlook.com (2603:10b6:803:51::24) by SN4PR0601MB3790.namprd06.prod.outlook.com (2603:10b6:803:4a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Tue, 21 Apr 2020 23:51:21 +0000 Received: from SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::b496:c392:d8af:ee14]) by SN4PR0601MB3728.namprd06.prod.outlook.com ([fe80::b496:c392:d8af:ee14%3]) with mapi id 15.20.2921.030; Tue, 21 Apr 2020 23:51:21 +0000 From: "Scheffenegger, Richard" To: Jonathan Looney , Michael Tuexen , Lawrence Stewart , Randall Ray Stewart , Tom Jones CC: "rgrimes@freebsd.org" , "transport@freebsd.org" Subject: Categorizing Diffs for Review/Transport Call. Thread-Topic: Categorizing Diffs for Review/Transport Call. Thread-Index: AdYYN8FD4eIugHqJQ/quI9+5gpsrTg== Date: Tue, 21 Apr 2020 23:51:21 +0000 Message-ID: Accept-Language: de-AT, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 40ba95db-d2aa-4b2d-b205-08d7e64ee4c4 x-ms-traffictypediagnostic: SN4PR0601MB3790: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 038002787A x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SN4PR0601MB3728.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10009020)(4636009)(366004)(39860400002)(136003)(396003)(346002)(376002)(33656002)(8676002)(86362001)(54906003)(110136005)(66446008)(66946007)(66556008)(66476007)(76116006)(7696005)(2906002)(6506007)(5660300002)(26005)(186003)(478600001)(55016002)(9686003)(52536014)(316002)(71200400001)(8936002)(4326008)(81156014)(64756008); DIR:OUT; SFP:1101; received-spf: None (protection.outlook.com: netapp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ir0tfxAMxUVhwHCFR+LWEJPmhn3JN5KaAvBj2iHd5OWEd+5XP37oA0gKyrvO9pO1dSk6IPrTTmQl2wFqathdR+UIazOQc+jkN8nW9wJ+yawZPHKdrGiG6b562wKU/tRbnXTK82+lDwShqS2zat/W3Q4umQo+qYIEcqqdya9XpS87WbVUXqhzlny1ZClEstJNPcI5J3Vh7B05F44y4uOXXI3T8B8h9KK9mEHk0Qb3drPEqvRTiI2vcbquAjSp2ZKpuh+ekgUsWQ4LfAA1CZpH3pjpYq05q6eiYe4/kAfdLyxzTwMtBj4/BCAvLCfIX2uSYLTjnXKL8gjtYkNsoAqlLETe2XHYn6Fscx9KHfQWl2KMLJ+kFT6q6D5NeMN1xnEnGMHu8yLdIyvxORlwkWmfdSTz0NR4LEV5fCCeVMGXMBe88s7M7H44mCtIr9xU3IKV x-ms-exchange-antispam-messagedata: AcLABBX0BoaTIYc6TEmPpa+YktP8xu60f3hJzpvkB7HpXuf4829pr8PyzB+lx7+9iKPxjUQlsXzjULx7s3R2SKyD9JMLHwcHK8YA6qP9VJZAcODN7ldw84sjz8qMQIIBNbsfoJwFLov0DZTsOhsVUg== x-ms-exchange-transport-forked: True MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 40ba95db-d2aa-4b2d-b205-08d7e64ee4c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2020 23:51:21.5178 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w5mgvnqLmltqqsCECuKA25M0jA+HYnpy42+b3Iyt2Mf9OmOeJC6AM56t6tK7ETKl9qza0J5mYszTWh1Dw5MtHg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR0601MB3790 X-Rspamd-Queue-Id: 496L1m3CvPz4P1J X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=netapp.onmicrosoft.com header.s=selector1-netapp-onmicrosoft-com header.b=Eiztrsz6; dmarc=none; spf=pass (mx1.freebsd.org: domain of Richard.Scheffenegger@netapp.com designates 40.107.243.76 as permitted sender) smtp.mailfrom=Richard.Scheffenegger@netapp.com X-Spamd-Result: default: False [-4.89 / 15.00]; TO_DN_EQ_ADDR_SOME(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[netapp.onmicrosoft.com:s=selector1-netapp-onmicrosoft-com]; HAS_XOIP(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[netapp.com]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[netapp.onmicrosoft.com:+]; RCVD_IN_DNSWL_NONE(0.00)[76.243.107.40.list.dnswl.org : 127.0.3.0]; RCPT_COUNT_SEVEN(0.00)[7]; IP_SCORE(-1.39)[ipnet: 40.64.0.0/10(-3.73), asn: 8075(-3.19), country: US(-0.05)]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1]; RWL_MAILSPIKE_POSSIBLE(0.00)[76.243.107.40.rep.mailspike.net : 127.0.0.17] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Apr 2020 23:51:26 -0000 I thought I'd categorize the Diffs I have currently pending for review into= different bins; Those which I deem more critical are those with interoperability issues tow= ards other stacks (and RFC violations): 23364 24237 24515 23353 Correctness (RFC compliance) ECN: 23364 (ECN: CWR only with new data) - critical for interoper= ability with older Linux 23373 (parallel open case - ECN feature) Interoperability: 24237 (premature window update with outdated SACK - fix alik= e MacOS and what jtl suggested, by moving upcall to end of input processing= ; side effect is fewer locking issues) - poor performance with most Linux 23371 (parallel open case - feature negotiation) 24515 receive window retraction with window scaling - potent= ial deadlock with older Linux Performance 22438 after_idle ssthresh to =BE cwnd per 2861 (performance) Cubic: 23353 Cubic no minimal cwnd (set to 2 MSS in this diff) 23655 Cubic base_time start only after slowstart is finished Misc: 21117 optimize TCPCB by replacing unnecessarily large uint64= _t with uint8_t and bounded increment 23160 SACK partial ACK always activate TT_REXMT instead of T= T_PERSIST (no longer reproduceable with other cubic fixes) -> abandon? Feature s: 23230 ECN+ / ECN++ (new sysctl, default disabled; needed for= DCTCP later) 18624 Improve SACK scoreboard bookkeeping 18892 SACK PRR 18985 RFC6675 SACK (rescue retransmission - for transactiona= l IO). Finally, I have AccECN on my plate, but that partially depends on prior boo= kkeeping fixes, and finalization of the current draft; Richard Scheffenegger