From owner-svn-src-all@FreeBSD.ORG Sat Aug 27 15:28:58 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0F6451065672; Sat, 27 Aug 2011 15:28:58 +0000 (UTC) (envelope-from brueffer@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id F388D8FC13; Sat, 27 Aug 2011 15:28:57 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id p7RFSvuI011093; Sat, 27 Aug 2011 15:28:57 GMT (envelope-from brueffer@svn.freebsd.org) Received: (from brueffer@localhost) by svn.freebsd.org (8.14.4/8.14.4/Submit) id p7RFSvGp011091; Sat, 27 Aug 2011 15:28:57 GMT (envelope-from brueffer@svn.freebsd.org) Message-Id: <201108271528.p7RFSvGp011091@svn.freebsd.org> From: Christian Brueffer Date: Sat, 27 Aug 2011 15:28:57 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r225215 - head/bin/ed X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Aug 2011 15:28:58 -0000 Author: brueffer Date: Sat Aug 27 15:28:57 2011 New Revision: 225215 URL: http://svn.freebsd.org/changeset/base/225215 Log: Fix memory leaks in error cases. PR: 159011 Submitted by: Henning Petersen Approved by: re (kib) MFC after: 1 week Modified: head/bin/ed/buf.c Modified: head/bin/ed/buf.c ============================================================================== --- head/bin/ed/buf.c Sat Aug 27 14:24:27 2011 (r225214) +++ head/bin/ed/buf.c Sat Aug 27 15:28:57 2011 (r225215) @@ -94,6 +94,7 @@ put_sbuf_line(const char *cs) ; if (s - cs >= LINECHARS) { errmsg = "line too long"; + free(lp); return NULL; } len = s - cs; @@ -102,6 +103,7 @@ put_sbuf_line(const char *cs) if (fseeko(sfp, (off_t)0, SEEK_END) < 0) { fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot seek temp file"; + free(lp); return NULL; } sfseek = ftello(sfp); @@ -112,6 +114,7 @@ put_sbuf_line(const char *cs) sfseek = -1; fprintf(stderr, "%s\n", strerror(errno)); errmsg = "cannot write temp file"; + free(lp); return NULL; } lp->len = len;