From owner-freebsd-current Sat Jun 20 13:22:48 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id NAA03797 for freebsd-current-outgoing; Sat, 20 Jun 1998 13:22:48 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from mail.camalott.com (root@mail.camalott.com [208.203.140.2]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id NAA03790 for ; Sat, 20 Jun 1998 13:22:43 -0700 (PDT) (envelope-from joelh@gnu.org) Received: from detlev.UUCP (tex-72.camalott.com [208.229.74.72] (may be forged)) by mail.camalott.com (8.8.7/8.8.5) with ESMTP id PAA32077; Sat, 20 Jun 1998 15:21:04 -0500 Received: (from joelh@localhost) by detlev.UUCP (8.8.8/8.8.8) id PAA17948; Sat, 20 Jun 1998 15:21:14 -0500 (CDT) (envelope-from joelh) Date: Sat, 20 Jun 1998 15:21:14 -0500 (CDT) Message-Id: <199806202021.PAA17948@detlev.UUCP> To: tlambert@primenet.com CC: tlambert@primenet.com, fenner@parc.xerox.com, peter@netplex.com.au, current@FreeBSD.ORG In-reply-to: <199806202002.NAA17957@usr02.primenet.com> (message from Terry Lambert on Sat, 20 Jun 1998 20:02:49 +0000 (GMT)) Subject: Re: Bogus errno twiddling by lstat... From: Joel Ray Holveck Reply-to: joelh@gnu.org References: <199806202002.NAA17957@usr02.primenet.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG >> If, however, you don't like our malloc's current implementation, and >> think that errno should be saved and restored across a successful >> call, and that the lost cycles would be worthwhile, then diffs would >> be perfectly welcome, I'm sure. > Since the malloc.conf file is unnecessarily being looked for in the > printf case (since ld.so already caused it to be looked for, and didn't > find it), I think the redundant call to llok for it is certainly worth > removing. > I would also not save and restore state, except in anticipation of > an error. If the cached value were being used (as it should be), > then the malloc.conf reference shouldn't have been tried (and not being > tried, the errno would not be in danger of being blown). Okay. I agree, cachine the call is helpful. So are you going to hack it up? Best, joelh -- Joel Ray Holveck - joelh@gnu.org - http://www.wp.com/piquan Fourth law of programming: Anything that can go wrong wi sendmail: segmentation violation - core dumped To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message