From owner-freebsd-current@FreeBSD.ORG Tue Dec 4 17:55:50 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1761B16A418; Tue, 4 Dec 2007 17:55:50 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 83FD613C442; Tue, 4 Dec 2007 17:55:49 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.1/8.14.1) with ESMTP id lB4HtgDj047701; Tue, 4 Dec 2007 09:55:42 -0800 (PST) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.1/8.14.1/Submit) id lB4HtfkQ047700; Tue, 4 Dec 2007 09:55:41 -0800 (PST) (envelope-from obrien) Date: Tue, 4 Dec 2007 09:55:41 -0800 From: "David O'Brien" To: Giorgos Keramidas Message-ID: <20071204175541.GC47398@dragon.NUXI.org> Mail-Followup-To: obrien@freebsd.org, Giorgos Keramidas , Luoqi Chen , freebsd-current@freebsd.org, youshi10@u.washington.edu, FreeBSD Release Engineers , Bruce Evans , Alexander Kabaev References: <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071129233842.GA57951@ace.netcins.ceid.upatras.gr> <200711292024.lATKOq5R000769@freefall.freebsd.org> <20071130013826.GA66484@kobe.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071130013826.GA66484@kobe.laptop> X-Operating-System: FreeBSD 7.0-CURRENT User-Agent: Mutt/1.5.16 (2007-06-09) Cc: FreeBSD Release Engineers , Alexander Kabaev , youshi10@u.washington.edu, freebsd-current@freebsd.org, Bruce Evans Subject: Re: [PATCH] gprof's broken in 7-CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@freebsd.org List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2007 17:55:50 -0000 I'm not sure what the action item is. This looks OK to me - do you want me to commit it to HEAD right now so we can let it soak a little before discussing it with RE? -- David On Fri, Nov 30, 2007 at 03:38:27AM +0200, Giorgos Keramidas wrote: > Please pass this through the release engineering team, Bruce Evans > (who has the largest number of commits to the file), and our gcc > folks (David O'Brien, and Alexander Kabaev). > > If it is considered safe for RELENG_7 (what will become 7.0-RELEASE), > then it's probably a good idea to commit it. It looks `harmless' to me, > but it certainly won't harm to get a proper review from much more > experienced people (added to the Cc: list). > > It would be marvellous to have non-broken profiling in 7.0. > > - Giorgos > > On 2007-11-30 01:38, Nikos Ntarmos wrote: > > I couldn't wait for Garrett :) so I went on and tested your patch and > > gprof seems to work fine for me (at least for the executables I was > > interested in profiling anyway). This is i386 on a 7.0-BETA3 kernel and > > 7.0-BETA1 world. What are the chances for this to be committed in time > > for 7.0R? > > On 2007-11-29 20:24, Luoqi Chen wrote: > > Garrett, would you like to try out my fix? It's actually quite simple, -- -- David (obrien@FreeBSD.org)