From owner-svn-src-head@FreeBSD.ORG Tue Jan 21 22:19:24 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC039804 for ; Tue, 21 Jan 2014 22:19:24 +0000 (UTC) Received: from nm12.bullet.mail.ne1.yahoo.com (nm12.bullet.mail.ne1.yahoo.com [98.138.90.75]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 6EADF1F41 for ; Tue, 21 Jan 2014 22:19:24 +0000 (UTC) Received: from [98.138.100.113] by nm12.bullet.mail.ne1.yahoo.com with NNFMP; 21 Jan 2014 22:12:47 -0000 Received: from [98.138.226.30] by tm104.bullet.mail.ne1.yahoo.com with NNFMP; 21 Jan 2014 22:12:47 -0000 Received: from [127.0.0.1] by smtp201.mail.ne1.yahoo.com with NNFMP; 21 Jan 2014 22:12:47 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1390342367; bh=KOuUm53kP3Puz8ZdtUDpr12kdspuUjH/L+//5B4jw4U=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc:Content-Transfer-Encoding:Message-Id:References:To:X-Mailer; b=qSEgH79AyABODl0cpBNHO51rN8hX+J83xN145y3Sv6VE9jEEKfo1UBvZRZ2m9+08OW82xVkGcBk9wDrH9mziPNnGQVYjqRp9hlYGm/oIHakVZzbv7wCM/yI0+qrI8lxBB5yYHZRKAgOzwIgiv3b8XWU3/VHOFJ3oRbOqxv2FY/c= X-Yahoo-Newman-Id: 188643.44889.bm@smtp201.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: xXqMqGYVM1nh3rQl2NHZPCRXZc1Im._RZvUgoWGXFZ2bkD_ hRnER1WMP6wFz.dX.AfnDzV9jYELmPb0Nj0I7Z_s2cYVFW5sAWAtINwCXqB2 KZk_2D5HYTeyN5KxRcH20iqDvtlIme.YYzr8w1TTog3sFnmQ4RHOk_157Ys2 93joSt3gdOAdo6S1GYbKapSO23UqrYe_EJW6MGTNEQvs4Nvn0uxJBtG1p6xk rdFZIeyehHXnHTFCkn8e_ClGpoJmyehbbfDH34T83f09wg0Slc35Np9vTI7b XfWq75L5YVN3frmkuFJd8T4.M0T8QBleFxGc4s5VBOfOaa_nfIxtndMjYUQu VRfr1fHVNQoxlpVZTYAUDoL_WKLfFMXuutzYYOvgCUXr.r0qXBvB2CoH2eBL k5irTOpBaTxIrrFI4bRZT2DVyitywcEBaMYHcXPN.KlVMA8wHcKlNCiYtcQb cpumICoDfZth082ZUXbYNNW.RezoEZGx3Na8Lh95V8Mdd1jbJz2MG09ePdKv EdLSw4b8pxg5Fe9FPDdUeh0IBaowJmKY6f5crpL5DQwuriH07qsYnGQFNUyN fpqMH X-Yahoo-SMTP: clhABp.swBB7fs.LwIJpv3jkWgo2NU8- X-Rocket-Received: from [192.168.5.229] (scott4long@64.134.151.138 with plain [63.250.193.228]) by smtp201.mail.ne1.yahoo.com with SMTP; 21 Jan 2014 14:12:47 -0800 PST Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r260898 - head/sys/kern From: Scott Long In-Reply-To: <201401211126.18930.jhb@freebsd.org> Date: Tue, 21 Jan 2014 15:12:30 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201401200159.s0K1xa5X012123@svn.freebsd.org> <1536225.gsjt6oXMt2@pippin.baldwin.cx> <20140120171844.69e065fb@kan.dyndns.org> <201401211126.18930.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1827) Cc: src-committers@freebsd.org, Neel Natu , svn-src-all@freebsd.org, Rui Paulo , svn-src-head@freebsd.org, Alexander Kabaev X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 22:19:24 -0000 On Jan 21, 2014, at 9:26 AM, John Baldwin wrote: > On Monday, January 20, 2014 5:18:44 pm Alexander Kabaev wrote: >> On Mon, 20 Jan 2014 11:32:29 -0500 >> John Baldwin wrote: >>=20 >>> On Sunday 19 January 2014 18:18:03 Rui Paulo wrote: >>>> On 19 Jan 2014, at 17:59, Neel Natu wrote: >>>>> Author: neel >>>>> Date: Mon Jan 20 01:59:35 2014 >>>>> New Revision: 260898 >>>>> URL: http://svnweb.freebsd.org/changeset/base/260898 >>>>>=20 >>>>> Log: >>>>> Bump up WITNESS_COUNT from 1024 to 1536 so there are sufficient >>>>> entries for >>>>> WITNESS to actually work. >>>>=20 >>>> This value should be automatically tuned... >>>=20 >>> How do you propose to do so? This is the count of locks initialized >>> before witness' own SYSINIT is executed and the array it sizes is >>> allocated statically at compile time. This used to not be a static >>> array, but an intrusive list embedded in locks themselves, but we >>> decided to shave a pointer off of each lock that was only used for >>> that and to use a statically sized table instead. >>>=20 >>> --=20 >>> John Baldwin >>=20 >> As + * MAXCPU, as evidently most recent >> overflows reported were caused by jacking MAXCPU up from its default >> value?=20 >=20 > If raising MAXCPU changes the number of unique lock names used, then = the > locks are named incorrectly. We don't use the 'pid' in the name for > PROC_LOCK precisely so that WITNESS will treat them all the same so > that if if it learns a lock order for pid 37 it enforces the same lock > order for pid 38. Device locks should follow a similar rule. They > should generally not include the device name (and in some cases they > really shouldn't even have the driver name). Why shouldn=92t they have a driver and device name? Wouldn=92t it help = identify possible deadlocks from driver instances calling into each other? Scott