From owner-svn-ports-all@freebsd.org  Mon Oct 24 16:24:39 2016
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59410C1FDBD;
 Mon, 24 Oct 2016 16:24:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 4E0D1CBC;
 Mon, 24 Oct 2016 16:24:39 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 4DE3111B1; Mon, 24 Oct 2016 16:24:39 +0000 (UTC)
Date: Mon, 24 Oct 2016 16:24:39 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r424560 - in head: audio/codec2
 emulators/i386-wine-staging emulators/open-vm-tools-nox11
 emulators/wine-staging graphics/djview4-qt4 java/langspec mail/mutt
 mail/qpopper mail/sympa mis...
Message-ID: <20161024162439.GB10879@FreeBSD.org>
References: <201610241018.u9OAIoLO063839@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201610241018.u9OAIoLO063839@repo.freebsd.org>
User-Agent: Mutt/1.6.1 (2016-04-27)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2016 16:24:39 -0000

On Mon, Oct 24, 2016 at 10:18:50AM +0000, Mathieu Arnold wrote:
> New Revision: 424560
> URL: https://svnweb.freebsd.org/changeset/ports/424560
> 
> Log:
>   OPTIONS_SET/OPTIONS_UNSET are global variables, they cannot be used in
>   ports Makefiles.
>   
>   So, replace them with OPTIONS_SLAVE, OPTIONS_EXCLUDE, OPTIONS_DEFAULT,
>   where appropriate.
> [...]
> +++ head/mail/qpopper/Makefile	Mon Oct 24 10:18:50 2016	(r424560)
> @@ -76,12 +76,6 @@ OS_DEFS+=	-DAPOP_ONLY
>  .endif
>  .endif
>  
> -# Do not install documentation since it is in pdf format and normally
> -# not used unless user wants it.
> -.if empty(PORT_OPTIONS:MDOCUMENTATION)
> -OPTIONS_UNSET+=	DOCS
> -.endif
> -
>  # If WITH_DRAC variable present in the environment, qpopper builds
>  # with Dynamic Relay Authorization Control support.
>  .if ${PORT_OPTIONS:MDRAC}
> @@ -161,7 +155,7 @@ do-install:
>  .if ${PORT_OPTIONS:MPOPPASSD}
>  	@${INSTALL_PROGRAM} ${WRKSRC}/password/poppassd ${STAGEDIR}${PREFIX}/libexec/qpoppassd
>  .endif
> -.if ${PORT_OPTIONS:MDOCS}
> +.if ${PORT_OPTIONS:MDOCUMENTATION}

Why not simply remove DOCUMENTATION in favor of standard DOCS altogether?

./danfe