Date: Tue, 19 Jan 2016 08:13:46 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= <des@des.no> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291941 - in head: lib/libpam/modules/pam_ssh secure/lib/libssh secure/libexec/sftp-server secure/libexec/ssh-keysign secure/libexec/ssh-pkcs11-helper secure/usr.bin/scp secure/usr.bin/... Message-ID: <569E60BA.6050007@FreeBSD.org> In-Reply-To: <86vb6phdug.fsf@desk.des.no> References: <201512071608.tB7G89BZ095366@repo.freebsd.org> <86vb6phdug.fsf@desk.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ImOUi8qoVMxdCLw0lxfNegh6WQNX2pVxe Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 1/19/2016 5:56 AM, Dag-Erling Sm=C3=B8rgrav wrote: > Bryan Drewery <bdrewery@FreeBSD.org> writes: >> Log: >> Replace unneeded manual dependency on header by adding it to SRCS. >> =20 >> bsd.lib.mk and bsd.prog.mk already depend all objs on headers in SRC= S if >> there is not yet a depend file. The headers in SRCS are never built= or >> installed. After 'make depend' the header was already added as a pr= oper >> dependency on the objects where needed. >=20 > This doesn't work. Try the following: >=20 > $ cd /usr/src/secure/lib/libssh > $ make depend && make > $ touch /usr/src/crypto/openssh/ssh_namespace.h > $ make Well, it sort of works with WITH_FAST_DEPEND which will be default very shortly. > ~/git/freebsd/secure/lib/libssh # make -j15 > ~/git/freebsd/secure/lib/libssh # touch ../../../crypto/openssh/ssh_nam= espace.h > ~/git/freebsd/secure/lib/libssh # make > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.authfd.o -MTauthfd.o -std=3Dgnu99 -fstack-prote= ctor-strong -Wno-pointer-sign - > -const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parent= heses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-loca= l-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-p= arentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh/../= =2E./../crypto/openssh/authfd > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.authfile.o -MTauthfile.o -std=3Dgnu99 -fstack-p= rotector-strong -Wno-pointer-si > used-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-pa= rentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-= local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -W= no-parentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh= /../../../crypto/openssh/au > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.bufaux.o -MTbufaux.o -std=3Dgnu99 -fstack-prote= ctor-strong -Wno-pointer-sign - > -const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parent= heses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-loca= l-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-p= arentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh/../= =2E./../crypto/openssh/bufaux > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.bufbn.o -MTbufbn.o -std=3Dgnu99 -fstack-protect= or-strong -Wno-pointer-sign -Wn > onst-variable -Wno-tautological-compare -Wno-unused-value -Wno-parenthe= ses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-local-= typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-par= entheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh/../..= /../crypto/openssh/bufbn.c > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.buffer.o -MTbuffer.o -std=3Dgnu99 -fstack-prote= ctor-strong -Wno-pointer-sign - > -const-variable -Wno-tautological-compare -Wno-unused-value -Wno-parent= heses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-loca= l-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-p= arentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh/../= =2E./../crypto/openssh/buffer > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.canohost.o -MTcanohost.o -std=3Dgnu99 -fstack-p= rotector-strong -Wno-pointer-si > used-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-pa= rentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-= local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -W= no-parentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh= /../../../crypto/openssh/ca > /usr/local/bin/ccache cc -O2 -pipe -DHAVE_LDNS=3D1 -I/root/git/freeb= sd/secure/lib/libssh/../../../contrib/ldns -I/root/git/freebsd/secure/lib= /libssh/../../../crypto/openssh -include ssh_namespace.h -include krb5_co= nfig.h -MD -MP -MF.depend.channels.o -MTchannels.o -std=3Dgnu99 -fstack-p= rotector-strong -Wno-pointer-si > used-const-variable -Wno-tautological-compare -Wno-unused-value -Wno-pa= rentheses-equality -Wno-unused-function -Wno-enum-conversion -Wno-unused-= local-typedef -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -W= no-parentheses -Qunused-arguments -c /root/git/freebsd/secure/lib/libssh= /../../../crypto/openssh/ch > ^Cmake: *** channels.o removed >=20 > The second "make" should rebuild everything, but it doesn't. Also, >=20 > $ grep -c ssh_namespace $(make -V.OBJDIR)/.depend > 0 >=20 That is expected. The dependency is defined in bsd.lib.mk. Granted it is dependent on .depend existing, but I am going to remove that check so it is always defined. --=20 Regards, Bryan Drewery --ImOUi8qoVMxdCLw0lxfNegh6WQNX2pVxe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJWnmDAAAoJEDXXcbtuRpfPV/8IAMt5x/czMMjby3QdEyh4alir QZzG1q80xHL3SgI6J+p6DKrye7BBqNt3boctFJUHxJ0/SLXjIphjYW6BwkH5R4N8 /p0KDfxLDsrsFPXff7UL5abB35P8v8t/0Dw+YDp5ukjWuVu1AvEbyiWEzOsJCpR/ 7Il8NqufuyVSiAxnAh7YGbsvfM1hStZcIM5VdCk7GkWiYTkHYVazgf+L5ZApcVs4 ZNZdx9X7hrygSDvel8sivsfQlN6xubzQZ7Hwyj8X3HfGaF/mNyxRIxbxqhWi7zb/ vnJG67XM1vJ3yjQvSxtlqtGPTifd1qvhMlmnlq2S6eOrpVcEl+qXr+6Dol12dIU= =3rnz -----END PGP SIGNATURE----- --ImOUi8qoVMxdCLw0lxfNegh6WQNX2pVxe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?569E60BA.6050007>