From owner-freebsd-gnome@FreeBSD.ORG Thu Feb 26 14:53:18 2009 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 20DE51065670 for ; Thu, 26 Feb 2009 14:53:18 +0000 (UTC) (envelope-from andrew.w.nosenko@gmail.com) Received: from mail-fx0-f158.google.com (mail-fx0-f158.google.com [209.85.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id 4C78E8FC08 for ; Thu, 26 Feb 2009 14:53:17 +0000 (UTC) (envelope-from andrew.w.nosenko@gmail.com) Received: by fxm2 with SMTP id 2so540737fxm.43 for ; Thu, 26 Feb 2009 06:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=1FNZufTMKVIjmrww0P/Urry54rWNHDzZZxry6/+TI9o=; b=sRloElWqUUWa14Laq3AtO9X+qFR+MISi1lChVTa9vXCNG9xFprDbNHFJFWPmpI2VNO ENz99oTzC7k9ydcSauouNN7d4eBW96xtQzC/Yk+HeGZ+K6gidLaIL6o4Tdcd3Umr0Xdw eyQDOgAk1Pw1M0YgI69tDch8e6qVXNOiNH/7Y= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=CQ1kTD2rBBQ/NoyyTvnuyRaStYuVQr8CRuX60ZuKwJurVmK36fyLDURH0/zo06Yje5 xEjYo2KtZPMA+hTUmz7jZSdxnTycAYT+jKw8sH17Mr9ZHnE8oPH8iF6icozt9MZw7D+g +ZQcqcULt9/SiJ94Dp+mNvJSc9/CJfq8Z+dfA= MIME-Version: 1.0 Received: by 10.181.152.15 with SMTP id e15mr474220bko.164.1235659996196; Thu, 26 Feb 2009 06:53:16 -0800 (PST) In-Reply-To: <20090226171804.8681e79c.stas@FreeBSD.org> References: <20090224021026.ba40bdc2.stas@FreeBSD.org> <1235598615.3297.60.camel@shumai.marcuscom.com> <20090226171804.8681e79c.stas@FreeBSD.org> Date: Thu, 26 Feb 2009 16:53:16 +0200 Message-ID: <6161f3180902260653x2a6705l69b36c01b41caca0@mail.gmail.com> From: "Andrew W. Nosenko" To: Stanislav Sedov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org Subject: Re: [FreeBSD port]: devel/glib20 X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Feb 2009 14:53:18 -0000 On Thu, Feb 26, 2009 at 4:18 PM, Stanislav Sedov wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On Wed, 25 Feb 2009 16:50:15 -0500 > Joe Marcus Clarke mentioned: > >> On Tue, 2009-02-24 at 02:10 +0300, Stanislav Sedov wrote: >> > -----BEGIN PGP SIGNED MESSAGE----- >> > Hash: SHA1 >> > >> > Hi! >> > >> > glib20 has a known filename encoding problem with non-utf8 >> > locales, because it doesn't perform names conversion from >> > internal UTF8 to current locale by default (it used to do >> > that some time ago). The patch included changes glib20 >> > behaviour to always do the conversion (this will work >> > for all non-UTF8 locales and will have no effect fot UTF8 >> > ones). This is effectively the same redhat & co does in >> > their deistributions. >> > >> > Comments? >> >> I have no objection, but I don't typically run into problems with >> non-UTF-8 locales. I think it would be safer if you made this into an >> OPTION, and added this as an extra patch if the OPTION is enabled. >> > > Doesn't running gtk/glib (e.g. sylpheed, gimp) apps with non-UTF locale > break filenames for you? From looking into the code it's always the case > for non-UTF locales (well, if you running ISO8859-1 you shouldn't have > problems too). On the other hand enabling LANG-based locale detection should > not hurt prefromance much (I think the overhead of parsing LANG is neglible). > Sure, we can OPTIONfy this, but I belive the options should be enabled by > default in this case (otherwise, people will continue to step onto this > bug). Major Linux distributions also have this option turned on by default > to match the behavior of older version of glib where the locale detection > code was always enabled. > Why you want to patch Glib for turn this behavior on by default instead of just install file in the /usr/local/etc/profile.d ? profile.d approrach is reversible (I can unset enviroment variable), while patching Glib for remove patch ... slightly ugly at least, IMHO. -- Andrew W. Nosenko