From owner-freebsd-fs@FreeBSD.ORG Tue Nov 25 15:11:10 2008 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9A2D11065679 for ; Tue, 25 Nov 2008 15:11:10 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: from yw-out-2324.google.com (yw-out-2324.google.com [74.125.46.30]) by mx1.freebsd.org (Postfix) with ESMTP id 4EA578FC19 for ; Tue, 25 Nov 2008 15:11:10 +0000 (UTC) (envelope-from josh.carroll@gmail.com) Received: by yw-out-2324.google.com with SMTP id 9so1071299ywe.13 for ; Tue, 25 Nov 2008 07:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:reply-to :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=XR6Vnj6YGXBsIv5h/CS4qPwS++MUIR88S/RJB1E8yFo=; b=U3V03csqKVSqbuJ06+wQgMzezPyapB3xlUxnXx+TpxFXXNwqEtDFZi7fBKfNY3w30b P7TN6Ra59Ad3MMC8sKlhmYBYvlHDDgeMR07DE3MetMEUYsOEuBltJyOFhFT1whZEQY7t o7O5d5OlFRanc6FcSbVETHTf6xoHnv9/ctxhs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:reply-to:to:subject:cc:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:references; b=ctTj0LEr494K9ehKvPlg/RBUHp0+7wdr6NvTM9a++Zm9ZLQrAtblzq4mwKKix4wWJ6 MHyZ6isywJ2mj53+/8oVCQh2cQ60EJEOQx0huxUZjVznC/t7YcVn5Tecz0N2rH+oKy+f Ioo8OK0WOTLea8t/Y9YqCbK7EZL5ULSTc2o34= Received: by 10.151.149.14 with SMTP id b14mr9306415ybo.243.1227625869560; Tue, 25 Nov 2008 07:11:09 -0800 (PST) Received: by 10.150.218.5 with HTTP; Tue, 25 Nov 2008 07:11:09 -0800 (PST) Message-ID: <8cb6106e0811250711x39775d2asd601e8a53eaaeac7@mail.gmail.com> Date: Tue, 25 Nov 2008 10:11:09 -0500 From: "Josh Carroll" To: "Kostik Belousov" In-Reply-To: <20081125150342.GL2042@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <8cb6106e0811241129o642dcf28re4ae177c8ccbaa25@mail.gmail.com> <20081125140601.GH2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250617q5fffb41exe20dfb8314fc4a9d@mail.gmail.com> <20081125142827.GI2042@deviant.kiev.zoral.com.ua> <8cb6106e0811250657q6fdf08b0x1e94f35fd0a7ed4f@mail.gmail.com> <20081125150342.GL2042@deviant.kiev.zoral.com.ua> Cc: freebsd-fs@freebsd.org, FreeBSD Stable Subject: Re: ext2 inode size patch - RE: PR kern/124621 X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: josh.carroll@gmail.com List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Nov 2008 15:11:10 -0000 > Ok, I describe my concern once more. I do not object against the checking > of the inode size. But, if inode size is changed, then some data is added > to the inode, that could (and usually does, otherwise why extend it ?) > change intrerpetation of the inode. Thus, we need a verification of the > fact that simply ignoring added fields does not damage filesystem or > cause user data corruption. Verification != testing. Ok, I see your point. I will do some more research into the ext2 inode structure on disk and see what happens when inode size > 128. > > Until we make this work, patch cannot go into the tree. > Understood, thanks for your attention. Regards, Josh