From owner-freebsd-hackers  Wed Sep  5 11: 1:29 2001
Delivered-To: freebsd-hackers@freebsd.org
Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5])
	by hub.freebsd.org (Postfix) with ESMTP id 0B3FC37B401
	for <hackers@freebsd.org>; Wed,  5 Sep 2001 11:01:25 -0700 (PDT)
Received: from hades.hell.gr (patr530-b030.otenet.gr [195.167.121.158])
	by mailsrv.otenet.gr (8.11.5/8.11.5) with ESMTP id f85I1M717660
	for <hackers@freebsd.org>; Wed, 5 Sep 2001 21:01:22 +0300 (EEST)
Received: (from charon@localhost)
	by hades.hell.gr (8.11.6/8.11.6) id f85GYOc00811
	for hackers@freebsd.org; Wed, 5 Sep 2001 19:34:25 +0300 (EEST)
	(envelope-from charon@labs.gr)
Date: Wed, 5 Sep 2001 19:34:24 +0300
From: Giorgos Keramidas <charon@labs.gr>
To: hackers@freebsd.org
Subject: usr.sbin/ac change - request for comments
Message-ID: <20010905193424.A686@hades.hell.gr>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
X-PGP-Fingerprint: 3A 75 52 EB F1 58 56 0D - C5 B8 21 B6 1B 5E 4A C2
X-URL: http://students.ceid.upatras.gr/~keramida/index.html
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-hackers.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-hackers>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-hackers>
X-Loop: FreeBSD.ORG

The code of usr.sbin/ac/ includes support for handling ":0.0" as
console logins, when CONSOLE_TTY is defined during compilation.
Looking at the code, and revisions from 1.2 and up, this doesn't seem
to be used.  Is there any reason why this should not be removed from
the sources.  It's not used anyway :/

I'm talking about pieces of code like the following:

    #ifdef CONSOLE_TTY
    static char 	*Console = CONSOLE_TTY;
    #endif

or parts like the even more exotic:

	    while ((c = getopt(argc, argv, "Dc:dpt:w:")) != -1) {
		    switch (c) {
		    ...
		    case 'c':
    #ifdef CONSOLE_TTY
			    Console = optarg;
    #else
			    usage();		/* XXX */
    #endif
			    break;

The code is cluttered all over with #ifdef'ed pieces of code that are
not used.  Is it really necessary that we keep these parts?

-giorgos


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message