From owner-svn-src-all@FreeBSD.ORG  Mon Feb  9 16:17:42 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 285BFFE8;
 Mon,  9 Feb 2015 16:17:42 +0000 (UTC)
Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net
 [199.48.129.229])
 by mx1.freebsd.org (Postfix) with ESMTP id 03B7783C;
 Mon,  9 Feb 2015 16:17:41 +0000 (UTC)
Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001)
 id 1BB135A9F25; Mon,  9 Feb 2015 16:17:41 +0000 (UTC)
Date: Mon, 9 Feb 2015 16:17:41 +0000
From: Brooks Davis <brooks@freebsd.org>
To: Warner Losh <imp@FreeBSD.org>
Subject: Re: svn commit: r278460 - head/sys/conf
Message-ID: <20150209161740.GA39452@spindle.one-eyed-alien.net>
References: <201502091604.t19G49Yh017650@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s"
Content-Disposition: inline
In-Reply-To: <201502091604.t19G49Yh017650@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Feb 2015 16:17:42 -0000


--SLDf9lqlvOQaIe6s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 09, 2015 at 04:04:09PM +0000, Warner Losh wrote:
> Author: imp
> Date: Mon Feb  9 16:04:08 2015
> New Revision: 278460
> URL: https://svnweb.freebsd.org/changeset/base/278460
>=20
> Log:
>   We need to create /boot/dtb since some use cases don't create a full
>   root with BSD.root.mtree, so it often times will not exist. Rather
>   than force the latter for an installkernel, just create the directory
>   with a comment about why.
>  =20
>   Submitted by: Guy Yur
>=20
> Modified:
>   head/sys/conf/dtb.mk
>=20
> Modified: head/sys/conf/dtb.mk
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/conf/dtb.mk	Mon Feb  9 16:04:01 2015	(r278459)
> +++ head/sys/conf/dtb.mk	Mon Feb  9 16:04:08 2015	(r278460)
> @@ -67,6 +67,10 @@ CLEANFILES+=3D${_dts:R:S/$/.dtb/}
>  realinstall: _dtbinstall
>  .ORDER: beforeinstall _kmodinstall
>  _dtbinstall:
> +# Need to create this because installkernel doens't invoke mtree with BS=
D.root.mtree
> +# to make sure the tree is setup properly. This may break ownership of $=
{DTBDIR}
> +# for no-root build.
> +	mkdir -p ${DESTDIR}${DTBDIR}

You could use -d avoid the ownership issue in the no-root case, but then yo=
u'll end up
with duplicate ${DTBDIR} entries if you have run installworld.  Conditional=
 creation
might be the least bad solution.  i.e.:

test -d ${DESTDIR}${DTBDIR} || ${INSTALL} -d -u root -g wheel ${DESTDIR}${D=
TBDIR}

-- Brooks

--SLDf9lqlvOQaIe6s
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlTY3aMACgkQXY6L6fI4GtS0gwCeLjEomuYL+W6SbiYM1UXWu2Vu
QcoAoLf9iXTRdVnRpyMAWrTG5U4vHz1c
=04Gi
-----END PGP SIGNATURE-----

--SLDf9lqlvOQaIe6s--