From owner-freebsd-geom@FreeBSD.ORG Thu Dec 30 19:34:59 2004 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3ED6D16A4CE; Thu, 30 Dec 2004 19:34:59 +0000 (GMT) Received: from critter.freebsd.dk (f170.freebsd.dk [212.242.86.170]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8935D43D48; Thu, 30 Dec 2004 19:34:58 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.13.1/8.13.1) with ESMTP id iBUJYuMM046918; Thu, 30 Dec 2004 20:34:56 +0100 (CET) (envelope-from phk@critter.freebsd.dk) To: Pawel Jakub Dawidek From: "Poul-Henning Kamp" In-Reply-To: Your message of "Thu, 30 Dec 2004 18:38:26 +0100." <20041230173826.GD784@darkness.comp.waw.pl> Date: Thu, 30 Dec 2004 20:34:56 +0100 Message-ID: <46917.1104435296@critter.freebsd.dk> Sender: phk@critter.freebsd.dk cc: Dag-Erling Sm?rgrav cc: geom@FreeBSD.org Subject: Re: GEOM_VOL panics when audio CD is present X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Dec 2004 19:34:59 -0000 In message <20041230173826.GD784@darkness.comp.waw.pl>, Pawel Jakub Dawidek wri tes: > >--jCrbxBqMcLqd4mOl >Content-Type: text/plain; charset=iso-8859-2 >Content-Disposition: inline >Content-Transfer-Encoding: quoted-printable > >On Thu, Dec 30, 2004 at 05:56:06PM +0100, Dag-Erling Sm?rgrav wrote: >+> Pawel Jakub Dawidek writes: >+> > The problem exists not only in geom_vol_ffs, but also in geom_vfs, I t= >hink. >+>=20 >+> I'm not sure what you're referring to. If you mean the code in >+> geom_vfs.c, none of it is used during tasting; it is only used in >+> situations where the file system type and the sector size of the >+> underlying medium are already known. > >Code in geom_vfs.c can call g_io_request() with wrong offset/length. Only if there are bugs in the filesystem. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.