From owner-freebsd-current@FreeBSD.ORG Fri Aug 1 22:05:38 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AB9AD218 for ; Fri, 1 Aug 2014 22:05:38 +0000 (UTC) Received: from mail-qa0-x236.google.com (mail-qa0-x236.google.com [IPv6:2607:f8b0:400d:c00::236]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6CDA62EA0 for ; Fri, 1 Aug 2014 22:05:38 +0000 (UTC) Received: by mail-qa0-f54.google.com with SMTP id k15so4625255qaq.27 for ; Fri, 01 Aug 2014 15:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=a9e/Sj3rIpjAmplfzjHuMGxM481YO1SXz14KHkMmqgU=; b=OyurMh3+uvYge4+URmvhL/LbgMNaWrjIi4yVBMX6AonF6EWvYMN2hPNtvd0T6thmly j98OUJpgCCUtPVXfG9fJAlCPh2SKhBALCi76Id90hS+JWWjtD9pq6EoVLEPWvWn27nSj ZAO0sSzrF7V0Heyiy18NEIG6opFAvxngvsLr/xi+N6FIJIAnW4cof6sCJq4vW3+L1tXD mTy+/kAKsxGq7aLcvF3ULZF/5ckBh/zaMCNbNS6R2xRNvfxjrFJYebHWdcN5UrJcasCj XqWK9IiyiSKqlLu06kwjC+KMi45ve3ipx/XXueBYFDiOiaix34R9QySKmdyAnVqmDkAG qTng== MIME-Version: 1.0 X-Received: by 10.224.30.1 with SMTP id s1mr14053955qac.70.1406930737523; Fri, 01 Aug 2014 15:05:37 -0700 (PDT) Received: by 10.140.48.2 with HTTP; Fri, 1 Aug 2014 15:05:37 -0700 (PDT) In-Reply-To: <20140801193403.GE50495@funkthat.com> References: <20140801193403.GE50495@funkthat.com> Date: Sat, 2 Aug 2014 00:05:37 +0200 Message-ID: Subject: Re: domain_add(xxx) after domainfinalize... From: Svatopluk Kraus To: freebsd-current@freebsd.org Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.18 Cc: jmg@funkthat.com X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 22:05:38 -0000 Just what I've got in January 2011: http://lists.freebsd.org/pipermail/freebsd-hackers/2011-January/034037.html Svata On Fri, Aug 1, 2014 at 9:34 PM, John-Mark Gurney wrote: > So, I have a laptop that devd loads the bluetooth module every time.. > > This means I get the following error on every boot: > WARNING: attempt to domain_add(bluetooth) after domainfinalize() > WARNING: attempt to domain_add(netgraph) after domainfinalize() > > Is there any real benefit to this warning? I just looked at the code, > and the domain gets added despite the warning... > > Also, it looks like the pervious warning, we should just make that an > if/panic since it's clearly a programming bug, or kill the ifndef > INVARIANTS... > > Index: uipc_domain.c > =================================================================== > --- uipc_domain.c (revision 266964) > +++ uipc_domain.c (working copy) > @@ -227,15 +227,6 @@ > printf("WARNING: attempt to domain_add(%s) before " > "domaininit()\n", dp->dom_name); > #endif > -#ifdef notyet > - KASSERT(domain_init_status < 2, > - ("attempt to domain_add(%s) after domainfinalize()", > - dp->dom_name)); > -#else > - if (domain_init_status >= 2) > - printf("WARNING: attempt to domain_add(%s) after " > - "domainfinalize()\n", dp->dom_name); > -#endif > mtx_unlock(&dom_mtx); > } > > > -- > John-Mark Gurney Voice: +1 415 225 5579 > > "All that I will do, has been done, All that I have, has not." > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >