From owner-cvs-all Wed Apr 12 19:16:55 2000 Delivered-To: cvs-all@freebsd.org Received: from mail.af.airnet.ne.jp (mail.af.airnet.ne.jp [210.159.66.49]) by hub.freebsd.org (Postfix) with ESMTP id E31C637BB18; Wed, 12 Apr 2000 19:16:48 -0700 (PDT) (envelope-from imura@af.airnet.ne.jp) Received: from imurar (atom.nttdtec.co.jp [210.161.252.51]) by mail.af.airnet.ne.jp (8.8.8/3.6W/06/13/98-AF.AIRNET.NE.JP) with SMTP id LAA28822; Thu, 13 Apr 2000 11:16:46 +0900 Message-ID: <006101bfa4ee$cdff1000$6010a8c0@nttdtec.co.jp> From: "R. Imura" To: "Satoshi - Ports Wraith - Asami" Cc: , , References: <20000412005730F.imura@cs.titech.ac.jp> <86bt3gk2oi.wl@archon.local.idaemons.org> <20000412083621F.imura@cs.titech.ac.jp> Subject: Re: cvs commit: ports/chinese Makefile.inc ports/german Makefile.inc ports/japanese Makefile.inc ports/korean Makefile.inc ports/russian Makefile.inc ports/vietnamese Makefile.inc Date: Thu, 13 Apr 2000 11:19:43 +0900 MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.00.2919.6600 X-MimeOLE: Produced By Microsoft MimeOLE V5.00.2919.6600 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Sorry for my late reply. > * Do we have to move all CATEGORIES variables to Makefile.inc? > > We don't have to, but that was one of the things I thought about too. > There can be a "CATEGORIES+=whatever" in all the Makefile.inc's. That > way we can reduce most of the CATEGORIES lines (leaving only virtual > and extra secondary categories). This could be even more beneficial > when we go to multi-level categories, since it will allow us to move > things around without having to change too much in the Makefiles > (basically the default category will mirror the directory structure). > > * I don't like it. > > Why not? Is there a case where a port in category X not having X in > the CATEGORIES line? I think, our ports' good point is each skeltons are independent and we can build many applications with very a few files. Yes, if no CATEGORIES in its Makefile, we can build with no problem, but if he really want in what category the port is, it requires a hole tree of ports. I just worry about it. (You know, master/slave ports are the out of this case) About PKGNAMEPREFIX, even if I don't have Makefile.inc, I will know PKGNAMEPREFIX from its CATEGORIES, because CATEGORIES is still in each Makefiles. > * > We need to include both ${.CURDIR}/../Makefile.inc and > * > ${MASTERDIR}/../Makefile.inc (in the order named) for the reason I > * > mentioned above in 1). > * > * Ok, you mean "after" or "before" is not the issue, right? :) > > Um, I don't understand what you are trying to say, but the ordering > (${.CURDIR} before ${MASTERDIR}) is actually important so we can get > things like PKGNAMEPREFIX right. There should be misunderstandings. :( At first, I wondered about knu's "including ${.CURDIR}/../Makefile.inc before ${MASTERDIR}/Makefile is bad". I thought it is strange, I showed it will not happen, and I wanted to say "you don't have to think about it". But, knu didn't mention about ordering of Makefile.inc and Makefile again, I knew the issue kind of this is not his problem. I know well about first ${.CURDIR}../Makefile.inc, second ${MASTERDIR}../Makefile.inc is very important. - R. Imura To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message