From owner-cvs-all@FreeBSD.ORG Mon Oct 25 07:13:16 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 42C7A16A4CE; Mon, 25 Oct 2004 07:13:16 +0000 (GMT) Received: from tigra.ip.net.ua (tigra.ip.net.ua [82.193.96.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id EBBFB43D1F; Mon, 25 Oct 2004 07:13:14 +0000 (GMT) (envelope-from ru@ip.net.ua) Received: from localhost (rocky.ip.net.ua [82.193.96.2]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9P7DDqq065549; Mon, 25 Oct 2004 10:13:13 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: from tigra.ip.net.ua ([82.193.96.10]) by localhost (rocky.ipnet [82.193.96.2]) (amavisd-new, port 10024) with LMTP id 61530-07; Mon, 25 Oct 2004 10:13:06 +0300 (EEST) Received: from heffalump.ip.net.ua (heffalump.ip.net.ua [82.193.96.213]) by tigra.ip.net.ua (8.12.11/8.12.11) with ESMTP id i9P7CM5i065425; Mon, 25 Oct 2004 10:12:25 +0300 (EEST) (envelope-from ru@ip.net.ua) Received: (from ru@localhost) by heffalump.ip.net.ua (8.13.1/8.13.1) id i9P7C25S020069; Mon, 25 Oct 2004 10:12:02 +0300 (EEST) (envelope-from ru) Date: Mon, 25 Oct 2004 10:11:56 +0300 From: Ruslan Ermilov To: "David O'Brien" Message-ID: <20041025071156.GA19910@ip.net.ua> References: <200410241042.i9OAgFZq085437@repoman.freebsd.org> <20041025063924.GA86309@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20041025063924.GA86309@dragon.nuxi.com> User-Agent: Mutt/1.5.6i X-Virus-Scanned: by amavisd-new at ip.net.ua cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libsmb Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Oct 2004 07:13:16 -0000 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi David, First, apologies for not sending you a HEADS UP. I wanted to do it but forgot. On Sun, Oct 24, 2004 at 11:39:24PM -0700, David O'Brien wrote: > On Sun, Oct 24, 2004 at 10:42:15AM +0000, Ruslan Ermilov wrote: > > ru 2004-10-24 10:42:15 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > lib/libsmb Makefile=20 > > Log: > > -O2 compile isn't quite ready for WARNS=3D2 yet. >=20 > Would you PLEASE let me fix my own problems OR send me a direct email > that you reverted my commit?? I just spent 30 minutes trying to > reproduce the tender box errors on two different machines. Which had me > puzzled since I saw no changes to contrib/smbfs since my commit. >=20 Ahem, our friend tinderbox was broken for five days. > Hum... you know... should I go to Core about you backing out my commit?? > Since we don't officially support a userland at -O2 I wonder what the > justification of your commit is... > =20 Don't we? This is what's now in our make.conf(5) manpage: : CFLAGS (str) Controls the compiler setting when compiling C c= ode. : Optimization levels other than -O and -O2 are not sup- : ported. BDECFLAGS is provided as a set of gcc(1) sett= ings : suggested by Bruce Evans for develop= ing : and testing changes. They can be used, if set, by: :=20 : CFLAGS+=3D${BDECFLAGS} So it clearly looks to me like -O2 is "officially supported". It's not about backing out your commit, it's about fixing a build breakage which was ignored for five days. Again, sorry for not sending you a HEADS UP, but I needed a tinderbox service up and running as I planned a massive makefiles commit. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --AhhlLboLdkugWU4S Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (FreeBSD) iD8DBQFBfKc8qRfpzJluFF4RAv6TAKCYM9f8gVIJJVOdU1trn+G7eXDNrgCgl1hB PzkVwyN5KelSKBBpdInIimM= =65jf -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S--