From owner-svn-src-all@freebsd.org  Sun Mar  4 11:29:29 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id DB0EFF29DC1;
 Sun,  4 Mar 2018 11:29:29 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smarthost1.greenhost.nl (smarthost1.greenhost.nl
 [195.190.28.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 770837696C;
 Sun,  4 Mar 2018 11:29:29 +0000 (UTC)
 (envelope-from ronald-lists@klop.ws)
Received: from smtp.greenhost.nl ([213.108.110.112])
 by smarthost1.greenhost.nl with esmtps
 (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2)
 (envelope-from <ronald-lists@klop.ws>)
 id 1esRpS-0001T6-5c; Sun, 04 Mar 2018 12:29:22 +0100
Content-Type: text/plain; charset=utf-8; format=flowed; delsp=yes
To: "Hans Petter Selasky" <hselasky@freebsd.org>, src-committers@freebsd.org, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org, "Colin Percival"
 <cperciva@tarsnap.com>
Subject: Re: svn commit: r330236 - head/sys/compat/linuxkpi/common/src
References: <201803011031.w21AVpNU076475@repo.freebsd.org>
 <01000161ee9cee29-0a02aaff-9052-41d2-a638-4bc673a41df6-000000@email.amazonses.com>
Date: Sun, 04 Mar 2018 12:29:28 +0100
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: "Ronald Klop" <ronald-lists@klop.ws>
Message-ID: <op.zfcnjexlkndu52@klop.ws>
In-Reply-To: <01000161ee9cee29-0a02aaff-9052-41d2-a638-4bc673a41df6-000000@email.amazonses.com>
User-Agent: Opera Mail/12.16 (FreeBSD)
X-Authenticated-As-Hash: 398f5522cb258ce43cb679602f8cfe8b62a256d1
X-Virus-Scanned: by clamav at smarthost1.samage.net
X-Spam-Level: /
X-Spam-Score: -0.2
X-Spam-Status: No, score=-0.2 required=5.0 tests=ALL_TRUSTED,
 BAYES_50 autolearn=disabled version=3.4.0
X-Scan-Signature: 919fae14bc17c74543a025539baad412
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Mar 2018 11:29:30 -0000

On Sun, 04 Mar 2018 02:25:17 +0100, Colin Percival <cperciva@tarsnap.com>  
wrote:

> On 03/01/18 02:31, Hans Petter Selasky wrote:
>> New Revision: 330236
>>   Correct the return value from flush_work() and flush_delayed_work()  
>> in the
>>   LinuxKPI to comply more with Linux. This fixes an issue when these  
>> functions
>>   are used in waiting loops.
>>
>>   MFC after:	1 week
>>   Sponsored by:	Mellanox Technologies
>
> In case the data point is useful: Merging this to stable/11 unbroke S3
> suspend/resume on my laptop (system76 Galago Pro, kabylake, using the
> drm-next-kmod port).
>


These data points are much more useful than commit messages that describe  
what the patch already shows and talk about 'an issue'. Every patch solves  
'an issue' (or creates some :-) ).

No personal pun intended. Just taking this example as general thoughts  
about commit messages.

Regards,
Ronald.