From owner-svn-src-all@FreeBSD.ORG Mon Jun 17 15:17:39 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7BE42836; Mon, 17 Jun 2013 15:17:39 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) by mx1.freebsd.org (Postfix) with ESMTP id 8C89F1D4A; Mon, 17 Jun 2013 15:17:38 +0000 (UTC) Received: by mail-wi0-f169.google.com with SMTP id c10so4174853wiw.0 for ; Mon, 17 Jun 2013 08:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=Au1aRSYG3lGEd/dR/tXgJbBm76M0fkmSXulgNOVfF0Y=; b=s1/4zU2x/dm0MFp84Wi5t1xoVDvQOfCZoNkpBw/6a9PdbsqM66sjR0L6urneJaRZZs dHg2ReuYmpsMN3tAzzbp3bPaOz7h0Z+rKWdyB4gqJe+6E8zIxt/QkCB1p/Dh7ACsAIX9 UyveiCGuzxKikc/1lCCkeaP8n/j15KfTmt561uE5P3yEkd1PnADT7M1nGwRKYRcvNrQA V3xK5/+40p13PPs+3OyktafJcJhhjlSJdY7pGQCdJbvZm173g/VLzHs+9cY/81MEYeGp YW/v8FEkV6Ev+St3kqoZXFG7LzsofCuTSbs23X1kmdVb7CxoSd4R33vhY0JSoo7/7iHq 5s8w== X-Received: by 10.180.198.194 with SMTP id je2mr5124187wic.36.1371482257636; Mon, 17 Jun 2013 08:17:37 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id fu14sm22712489wic.8.2013.06.17.08.17.36 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 17 Jun 2013 08:17:36 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 17 Jun 2013 17:17:34 +0200 From: Baptiste Daroussin To: Nathan Whitehorn Subject: Re: svn commit: r251843 - in head: contrib/dialog contrib/dialog/package contrib/dialog/package/debian contrib/dialog/po contrib/dialog/samples contrib/dialog/samples/copifuncs contrib/dialog/samples/i... Message-ID: <20130617151734.GC62733@ithaqua.etoilebsd.net> References: <201306171028.r5HAStR2033639@svn.freebsd.org> <51BF0F0F.1080907@freebsd.org> <20130617133644.GB62733@ithaqua.etoilebsd.net> <51BF1121.9000408@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IpbVkmxF4tDyP/Kb" Content-Disposition: inline In-Reply-To: <51BF1121.9000408@freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2013 15:17:39 -0000 --IpbVkmxF4tDyP/Kb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 17, 2013 at 08:37:37AM -0500, Nathan Whitehorn wrote: > On 06/17/13 08:36, Baptiste Daroussin wrote: > > On Mon, Jun 17, 2013 at 08:28:47AM -0500, Nathan Whitehorn wrote: > >> On 06/17/13 05:28, Baptiste Daroussin wrote: > >>> Author: bapt > >>> Date: Mon Jun 17 10:28:55 2013 > >>> New Revision: 251843 > >>> URL: http://svnweb.freebsd.org/changeset/base/251843 > >>> > >>> Log: > >>> Update dialog to 1.2-20130523 > >>> Level up WARNS > >> This seems to have broken bsdinstall. In particular, it is no longer > >> possible to get focus in the text input boxes in the partition editor's > >> (sade/bsdinstall partedit) "Add Partition" or "Modify Partition" > >> dialogs. Any chance you could try to figure out why? My Ncurses > >> debugging skills are unfortunately not great. > > I'm on it, yes, it seems like the dlg_forms is leaking the bindings fro= m the > > diskeditors form. > > > > I have a working patch but it is ugly. I'm trying to figure out the cle= an way to > > do so. > > > > regards, > > Bapt >=20 > Thanks much! Please let me know if I can do anything to help. I committed a workaround, I dicovered that the key on the Partition Editor window are not the one we expect to be, I see no errors yet in libdialog co= de, I'll continue investigating, but waiting for a proper fix, it is usable aga= in. regards, Bapt --IpbVkmxF4tDyP/Kb Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG/KI4ACgkQ8kTtMUmk6ExCDACfQYQ06Ukw3i2AWQEdPica+W9X BTwAn37dhEUXrJgOzeXZFkPMavF+1eQl =g3pE -----END PGP SIGNATURE----- --IpbVkmxF4tDyP/Kb--