From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Feb 3 20:34:53 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id F1AE78D4 for ; Tue, 3 Feb 2015 20:34:53 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BE12CAA6 for ; Tue, 3 Feb 2015 20:34:53 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t13KYrah035031 for ; Tue, 3 Feb 2015 20:34:53 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197234] [UPDATE] lang/execline: update to 2.0.2.0 and take maintainership Date: Tue, 03 Feb 2015 20:34:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: jbeich@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2015 20:34:54 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197234 Jan Beich changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jbeich@FreeBSD.org --- Comment #1 from Jan Beich --- Comment on attachment 152430 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D152430 unified diff to bump lang/execline to current > +LDFLAGS?=3D -s > +STRIPFLAGS?=3D -x Better use ${STRIP} or depend on ! ${PORT_OPTIONS:MDEBUG} and maybe use ven= dor `strip` make target e.g., # STRIP can only be `-s` or empty ALL_TARGET=3D all ${STRIP:S/-s/strip/} > +CC?=3D cc CC is always defined by sys.mk (fmake, bmake) or embedded (gmake). > +WRKSRC=3D ${WRKDIR}/${DISTNAME} No need to redefine the default value. > +USES=3D ${GMAKE} This works only by accident because the path to GNU make isn't an absolute = one. > + cd ${WRKSRC} && CC=3D${CC} ./configure \ > + --prefix=3D${LOCALBASE} \ > + --with-default-path=3D${LOCALBASE}/bin:/usr/bin:/bin \ > + --with-include=3D${LOCALBASE}/include \ > + --with-lib=3D${LOCALBASE}/lib/skalibs \ > + --enable-shared Define HAS_CONFIGURE and populate CONFIGURE_ARGS. This would also fix a case where CC contains spaces e.g., CC =3D distcc ccache gcc > do-build: > + cd ${WRKSRC} && ${GMAKE} Drop custom do-build and maybe define empty ALL_TARGET if `all` doesn't wor= k. > do-install: > + cd ${WRKSRC} && DESTDIR=3D${STAGEDIR} ${GMAKE} install Why not use default do-install and move the following lines under post-inst= all? > @${MKDIR} ${STAGEDIR}${DOCSDIR} > + cd ${WRKSRC} && ${INSTALL_MAN} ${DOCS} ${STAGEDIR}${DOCSDIR} INSTALL_MAN is for manpages only. Other docs should use INSTALL_DATA. > +lib/libexecline.so > +lib/libexecline.so.2 This requires USE_LDCONFIG in Makefile. --=20 You are receiving this mail because: You are the assignee for the bug.=