From owner-cvs-all@FreeBSD.ORG Mon Apr 11 00:10:17 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9722D16A4CE; Mon, 11 Apr 2005 00:10:17 +0000 (GMT) Received: from gw.celabo.org (gw.celabo.org [208.42.49.153]) by mx1.FreeBSD.org (Postfix) with ESMTP id F1FBC43D2F; Mon, 11 Apr 2005 00:10:16 +0000 (GMT) (envelope-from jacques@vidrine.us) Received: from gw.celabo.org (localhost [127.0.0.1]) by internal.gw.celabo.org (Postfix) with ESMTP id B4DEB3E2C2B; Sun, 10 Apr 2005 19:10:13 -0500 (CDT) Received: from lum.celabo.org (usen-221x249x212x60.ap-US01.usen.ad.jp [221.249.212.60]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "lum.celabo.org", Issuer "celabo.org CA" (verified OK)) by gw.celabo.org (Postfix) with ESMTP id 50C683E2C2A; Sun, 10 Apr 2005 19:10:13 -0500 (CDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by lum.celabo.org (Postfix) with ESMTP id 78BEB7182A; Mon, 11 Apr 2005 09:10:09 +0900 (JST) In-Reply-To: References: <200504081119.j38BJoZf036618@repoman.freebsd.org> <6715759dfc36ac3b48dc3efe8cfcd07d@FreeBSD.org> <8664yx2wwd.fsf@xps.des.no> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=ISO-8859-1; format=flowed Message-Id: Content-Transfer-Encoding: quoted-printable From: Jacques Vidrine Date: Mon, 11 Apr 2005 09:10:08 +0900 To: Jacques Vidrine X-Mailer: Apple Mail (2.619.2) X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on hellblazer.celabo.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= Subject: Re: cvs commit: src/libexec/rexecd rexecd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Apr 2005 00:10:17 -0000 On Apr 11, 2005, at 9:07 AM, Jacques Vidrine wrote: > On Apr 8, 2005, at 10:58 PM, Dag-Erling Sm=F8rgrav wrote: >> Jacques Vidrine writes: >>> Thanks for fixing, DES. Only, you have re-introduced some of the >>> bugs. You need to use getpwnam_r or copy the contents of the=20 >>> returned >>> struct passwd before continuing. >> >> Hmm, actually it should be sufficient to re-getpwnam() after the call >> to pam_setcred() in the child. There's nothing else that has the >> potential to screw up pwd. > > Yes, it would be sufficient, but wasteful (^_^). But, I'm not too=20 > concerned. (BTW, getpwnam is just a wrapper for getpwnam_r). Also, once resolved, RELENG_5 and RELENG_5_4 need to be sync'd with=20 HEAD before 5.4-RELEASE. Unfortunately, I'm not in a position to do so=20= right now. :-/ Cheers, --=20 Jacques A Vidrine / NTT/Verio nectar@celabo.org / jvidrine@verio.net / nectar@freebsd.org