From owner-svn-src-all@freebsd.org Mon Dec 16 17:09:03 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94A641C9315; Mon, 16 Dec 2019 17:09:03 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47c7673NLZz4306; Mon, 16 Dec 2019 17:09:03 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: by mail-qk1-f196.google.com with SMTP id a203so4802391qkc.3; Mon, 16 Dec 2019 09:09:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JSfxnJ1odUxIcncq2OawH8b1wELVF3cGDB9A7ua4n+A=; b=Na9TBpi7U7DsdJqBoLCR1piJVYSLM+maNjiUf69kD8N0eCAaNYp3i2kHG+83+Dlwsp FM/oG1sOKTC8DGbtT7w/3GBjT7ZwO5dpkt2RpozVhx2YW6hHmDQx+knHwhK3ithsszTV fDQmac0/DO14GrngTMX8vMyCrpw+ZZCxLlMfLBg/PjqN0voGupfh+BXl068XKrysWFyc jCGbYtK0Y8/vOLkgs1tjQwM4ZL9CBHar5Jcg3T+YejyVBqfFD1Iwh1vYIY6l4AJYGc6T 0ICSQa7INVGl+JFgQ/IDWk8P34tl/zNGX+sBrMNF/w6FHIlvP8XiMhTg/+O5XMUtM7Ux dgxw== X-Gm-Message-State: APjAAAXsWe4Y28bSdzz62xux/tPNpTJDRfy7qKoMIne7rp6J+LOhNJox haMhw1BMxuOxxl/A+C0PALjv6a1VVbs= X-Google-Smtp-Source: APXvYqxRxfo0WPdnE8dNswmlSREIuKUQUItfb/6XOh0Scnj/t3N5F98JvnLHs5CTWuVLUyRVweHp9A== X-Received: by 2002:a05:620a:1249:: with SMTP id a9mr253715qkl.147.1576516141879; Mon, 16 Dec 2019 09:09:01 -0800 (PST) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com. [209.85.219.44]) by smtp.gmail.com with ESMTPSA id v7sm7103347qtk.89.2019.12.16.09.09.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 09:09:01 -0800 (PST) Received: by mail-qv1-f44.google.com with SMTP id o18so3020072qvf.1; Mon, 16 Dec 2019 09:09:01 -0800 (PST) X-Received: by 2002:a05:6214:14b3:: with SMTP id bo19mr230025qvb.93.1576516140917; Mon, 16 Dec 2019 09:09:00 -0800 (PST) MIME-Version: 1.0 References: <201912152126.xBFLQoJ7037440@repo.freebsd.org> In-Reply-To: From: Ryan Libby Date: Mon, 16 Dec 2019 09:08:50 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r355784 - in head/sys: compat/linuxkpi/common/src dev/dpaa kern mips/nlm sys To: Ed Maste , Jeff Roberson Cc: src-committers , svn-src-all , svn-src-head , Mark Johnston , Konstantin Belousov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 47c7673NLZz4306 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 17:09:03 -0000 On Mon, Dec 16, 2019 at 7:30 AM Ed Maste wrote: > > On Sun, 15 Dec 2019 at 16:27, Jeff Roberson wrote: > > > > Author: jeff > > Date: Sun Dec 15 21:26:50 2019 > > New Revision: 355784 > > URL: https://svnweb.freebsd.org/changeset/base/355784 > > > > Log: > > schedlock 4/4 > > FYI i386, arm, arm64, riscv fail to boot now, with "panic: invalid count 2" > > Boot logs: > i386: https://ci.freebsd.org/job/FreeBSD-head-i386-test/7797/console > arm: https://ci.freebsd.org/hwlab/job/FreeBSD-device-head-beaglebone-test/1317/artifact/device_tests/beaglebone.boot.log > arm64: https://ci.freebsd.org/hwlab/job/FreeBSD-device-head-pinea64-test/1194/artifact/device_tests/pinea64.boot.log > riscv: https://ci.freebsd.org/hwlab/job/FreeBSD-device-head-pinea64-test/1194/artifact/device_tests/pinea64.boot.log > > arm64 is: > > panic: invalid count 2 > cpuid = 0 > time = 1 > KDB: stack backtrace: > db_trace_self() at db_trace_self_wrapper+0x28 > pc = 0xffff0000007359ec lr = 0xffff000000106744 > sp = 0xffff000056b063c0 fp = 0xffff000056b065d0 > > db_trace_self_wrapper() at vpanic+0x18c > pc = 0xffff000000106744 lr = 0xffff000000408128 > sp = 0xffff000056b065e0 fp = 0xffff000056b06690 > > vpanic() at panic+0x44 > pc = 0xffff000000408128 lr = 0xffff000000407ed8 > sp = 0xffff000056b066a0 fp = 0xffff000056b06720 > > panic() at sched_switch+0x81c > pc = 0xffff000000407ed8 lr = 0xffff000000434264 > sp = 0xffff000056b06730 fp = 0xffff000056b06810 > > sched_switch() at mi_switch+0x170 > pc = 0xffff000000434264 lr = 0xffff000000413690 > sp = 0xffff000056b06820 fp = 0xffff000056b06840 > > mi_switch() at cpu_idle+0xc8 > pc = 0xffff000000413690 lr = 0xffff0000007400a0 > sp = 0xffff000056b06850 fp = 0xffff000056b06860 > > cpu_idle() at sched_idletd+0x380 > pc = 0xffff0000007400a0 lr = 0xffff000000436a90 > sp = 0xffff000056b06870 fp = 0xffff000056b06940 > > sched_idletd() at fork_exit+0x7c > pc = 0xffff000000436a90 lr = 0xffff0000003c7ba4 > sp = 0xffff000056b06950 fp = 0xffff000056b06980 > > fork_exit() at fork_trampoline+0x10 > pc = 0xffff0000003c7ba4 lr = 0xffff0000007521ac > sp = 0xffff000056b06990 fp = 0x0000000000000000 > > KDB: enter: panic > [ thread pid 11 tid 100003 ] > Stopped at 0 > db> It looks like amd64 vs i386, riscv, etc are using different motifs in spinlock_exit(). Perhaps we just need to rearrange them to drop the spinlock count before critical_exit(), like in amd64. Ryan