From owner-svn-src-all@FreeBSD.ORG  Tue Oct 11 12:22:18 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4B585106564A;
	Tue, 11 Oct 2011 12:22:18 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 2347B8FC24;
	Tue, 11 Oct 2011 12:22:18 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id B8F1E46B09;
	Tue, 11 Oct 2011 08:22:17 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 5564A8A02E;
	Tue, 11 Oct 2011 08:22:17 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Christian Brueffer <brueffer@freebsd.org>
Date: Tue, 11 Oct 2011 08:22:16 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <201110111032.p9BAWNpw011158@svn.freebsd.org>
In-Reply-To: <201110111032.p9BAWNpw011158@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201110110822.16751.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Tue, 11 Oct 2011 08:22:17 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r226247 - head/sys/compat/linux
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 11 Oct 2011 12:22:18 -0000

On Tuesday, October 11, 2011 6:32:23 am Christian Brueffer wrote:
> Author: brueffer
> Date: Tue Oct 11 10:32:23 2011
> New Revision: 226247
> URL: http://svn.freebsd.org/changeset/base/226247
> 
> Log:
>   Properly free linux_gidset in case of an error.
>   
>   CID:		4136
>   Found with:	Coverity Prevent(tm)
>   MFC after:	1 week
> 
> Modified:
>   head/sys/compat/linux/linux_uid16.c
> 
> Modified: head/sys/compat/linux/linux_uid16.c
> 
==============================================================================
> --- head/sys/compat/linux/linux_uid16.c	Tue Oct 11 07:46:45 2011	
(r226246)
> +++ head/sys/compat/linux/linux_uid16.c	Tue Oct 11 10:32:23 2011	
(r226247)
> @@ -114,6 +114,7 @@ linux_setgroups16(struct thread *td, str
>  	linux_gidset = malloc(ngrp * sizeof(*linux_gidset), M_TEMP, M_WAITOK);
>  	error = copyin(args->gidset, linux_gidset, ngrp * sizeof(l_gid16_t));
>  	if (error)
> +		free(linux_gidset, M_TEMP);
>  		return (error);

This need braces now.

>  	newcred = crget();
>  	p = td->td_proc;
> 

-- 
John Baldwin