From owner-freebsd-bugs@FreeBSD.ORG Mon Feb 11 11:50:03 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2EED0413 for ; Mon, 11 Feb 2013 11:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id F19E014F for ; Mon, 11 Feb 2013 11:50:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r1BBo2hM091576 for ; Mon, 11 Feb 2013 11:50:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r1BBo25U091575; Mon, 11 Feb 2013 11:50:02 GMT (envelope-from gnats) Resent-Date: Mon, 11 Feb 2013 11:50:02 GMT Resent-Message-Id: <201302111150.r1BBo25U091575@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Olivier Cochard-Labbe Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D2CA03FB for ; Mon, 11 Feb 2013 11:48:54 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id B9D7B143 for ; Mon, 11 Feb 2013 11:48:54 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id r1BBmphS072979 for ; Mon, 11 Feb 2013 11:48:51 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id r1BBmp8Q072978; Mon, 11 Feb 2013 11:48:51 GMT (envelope-from nobody) Message-Id: <201302111148.r1BBmp8Q072978@red.freebsd.org> Date: Mon, 11 Feb 2013 11:48:51 GMT From: Olivier Cochard-Labbe To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/176027: flow control systcl consistency for em drivers X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2013 11:50:03 -0000 >Number: 176027 >Category: kern >Synopsis: flow control systcl consistency for em drivers >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Feb 11 11:50:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Olivier Cochard-Labbe >Release: 9.1-RELEASE >Organization: BSD Router Project >Environment: >Description: On my systems em(4) flow control can be configured with: dev.em.0.fc (if chipset depends of if_em.c) or dev.em.0.flow_control (if chipset depends of if_lem.c) For more consistency (but a POLA?), here is a small patch for if_lem.c that replace 'flow_control' usage by 'fc' usage. >How-To-Repeat: >Fix: Applying the patch. Patch attached with submission follows: --- sys/dev/e1000/if_lem.c.orig 2013-02-11 10:21:00.000000000 +0100 +++ sys/dev/e1000/if_lem.c 2013-02-11 10:21:20.000000000 +0100 @@ -458,7 +458,7 @@ #endif /* Sysctl for setting the interface flow control */ - lem_set_flow_cntrl(adapter, "flow_control", + lem_set_flow_cntrl(adapter, "fc", "flow control setting", &adapter->fc_setting, lem_fc_setting); >Release-Note: >Audit-Trail: >Unformatted: