From owner-cvs-src@FreeBSD.ORG  Fri Jan 12 12:20:02 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 7EFED16A40F;
	Fri, 12 Jan 2007 12:20:02 +0000 (UTC)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1])
	by mx1.freebsd.org (Postfix) with ESMTP id E1DDB13C44C;
	Fri, 12 Jan 2007 12:20:01 +0000 (UTC)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from smtp.atlantis.dp.ua (smtp.atlantis.dp.ua [193.108.46.231])
	by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id l0CC4m05033160; 
	Fri, 12 Jan 2007 14:04:48 +0200 (EET)
	(envelope-from dmitry@atlantis.dp.ua)
Date: Fri, 12 Jan 2007 14:04:48 +0200 (EET)
From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To: Warner Losh <imp@freebsd.org>
In-Reply-To: <200701120740.l0C7eULD026513@repoman.freebsd.org>
Message-ID: <20070112140211.G555@atlantis.atlantis.dp.ua>
References: <200701120740.l0C7eULD026513@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/kern kern_ntptime.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Jan 2007 12:20:02 -0000


Hello!

On Fri, 12 Jan 2007, Warner Losh wrote:
>    sys/kern             kern_ntptime.c
>  Log:
>  When ntp_gettime() was converted from a sysctl + wrapper to a system
>  call, its semantics were unintentionally changed.  It went from
>  returning the time state to returning 0 or -1.  Since 0 means time

   Shouldn't the manpage lib/libc/sys/ntp_gettime.2 also be updated? It claims
now:

RETURN VALUES
      The ntp_gettime() function returns the value 0 if successful; otherwise
      the value -1 is returned and the global variable errno is set to indicate
      the error.

      Possible states of the clock are:
 	...

So it still refers to old behaviour (return either 0 or -1), which is 
confusing enough.

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE