From owner-svn-src-projects@FreeBSD.ORG Mon Oct 14 21:41:36 2013 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id DBC9F663; Mon, 14 Oct 2013 21:41:36 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AF10A2A3D; Mon, 14 Oct 2013 21:41:36 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r9ELfaZX077332; Mon, 14 Oct 2013 21:41:36 GMT (envelope-from asomers@svn.freebsd.org) Received: (from asomers@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r9ELfa08077330; Mon, 14 Oct 2013 21:41:36 GMT (envelope-from asomers@svn.freebsd.org) Message-Id: <201310142141.r9ELfa08077330@svn.freebsd.org> From: Alan Somers Date: Mon, 14 Oct 2013 21:41:36 +0000 (UTC) To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r256462 - projects/zfsd/head/cddl/sbin/zfsd X-SVN-Group: projects MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Oct 2013 21:41:36 -0000 Author: asomers Date: Mon Oct 14 21:41:36 2013 New Revision: 256462 URL: http://svnweb.freebsd.org/changeset/base/256462 Log: Make zfsd WARNS=1 safe. cddl/sbin/zfsd/zfsd.h Make Reader's destructor virtual, because it has virtual functions cddl/sbin/zfsd/Makefile Add WARNS=1 and -Wall Submitted by: will Approved by: ken (mentor) Sponsored by: Spectra Logic Corporation Modified: projects/zfsd/head/cddl/sbin/zfsd/Makefile projects/zfsd/head/cddl/sbin/zfsd/zfsd.h Modified: projects/zfsd/head/cddl/sbin/zfsd/Makefile ============================================================================== --- projects/zfsd/head/cddl/sbin/zfsd/Makefile Mon Oct 14 21:34:49 2013 (r256461) +++ projects/zfsd/head/cddl/sbin/zfsd/Makefile Mon Oct 14 21:41:36 2013 (r256462) @@ -14,7 +14,7 @@ SRCS= callout.cc \ NO_MAN= YES -WARNS?= 0 +WARNS?= 1 INCFLAGS+= -I${.CURDIR}/../../../cddl/contrib/opensolaris/lib/libzpool/common INCFLAGS+= -I${.CURDIR}/../../../cddl/compat/opensolaris/include @@ -30,7 +30,7 @@ INCFLAGS+= -I${.CURDIR}/../../../sys/cdd INCFLAGS+= -I${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs INCFLAGS+= -I${.CURDIR}/../../../sys/cddl/contrib/opensolaris/uts/common/sys -CFLAGS= -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} +CFLAGS= -Wall -g -DNEED_SOLARIS_BOOLEAN ${INCFLAGS} DPADD= ${LIBZFS} ${LIBUTIL} ${LIBGEOM} ${LIBBSDXML} ${LIBSBUF} \ ${LIBNVPAIR} ${LIBUUTIL} Modified: projects/zfsd/head/cddl/sbin/zfsd/zfsd.h ============================================================================== --- projects/zfsd/head/cddl/sbin/zfsd/zfsd.h Mon Oct 14 21:34:49 2013 (r256461) +++ projects/zfsd/head/cddl/sbin/zfsd/zfsd.h Mon Oct 14 21:41:36 2013 (r256462) @@ -108,8 +108,12 @@ public: * \returns Amount of data that was actually read */ virtual ssize_t read(char* buf, size_t count) = 0; + + virtual ~Reader() = 0; }; +inline Reader::~Reader() {} + /*-------------------------------- FDReader -------------------------------*/ /**