From owner-cvs-src@FreeBSD.ORG Sun Oct 31 11:19:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E261116A4CE; Sun, 31 Oct 2004 11:19:46 +0000 (GMT) Received: from mail.ntplx.net (mail.ntplx.net [204.213.176.10]) by mx1.FreeBSD.org (Postfix) with ESMTP id 850B943D1F; Sun, 31 Oct 2004 11:19:46 +0000 (GMT) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) i9VBJjDu008631; Sun, 31 Oct 2004 06:19:45 -0500 (EST) Date: Sun, 31 Oct 2004 06:19:45 -0500 (EST) From: Daniel Eischen X-X-Sender: eischen@sea.ntplx.net To: Brian Feldman In-Reply-To: <200410310503.i9V53ofj011896@repoman.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.ntplx.net) cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Daniel Eischen List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Oct 2004 11:19:47 -0000 On Sun, 31 Oct 2004, Brian Feldman wrote: > green 2004-10-31 05:03:50 UTC > > FreeBSD src repository > > Modified files: > lib/libpthread/thread thr_mutex.c > Log: > Make pthread_mutex_trylock(3) return EBUSY on failure, as all software > packages expect and seems to be most correct according to the slightly- > ambiguous standards. > > MFC after: 1 month > Corroborated by: POSIX > Reviewed by: silence on threads@ I never saw this, and there has been a couple of long threads about it. The current behavior was deemed correct especially since default mutexes are error check mutexes. The rationale is that it provides a way for a thread to tell if it owns the mutex if EDEADLK is returned. Please back out and sorry for not seeing a posting on -threads. -- Dan Eischen