From owner-freebsd-amd64@FreeBSD.ORG  Fri May 20 19:40:06 2005
Return-Path: <owner-freebsd-amd64@FreeBSD.ORG>
Delivered-To: freebsd-amd64@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ABC3116A4D1
	for <freebsd-amd64@hub.freebsd.org>;
	Fri, 20 May 2005 19:40:06 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 832A743D8B
	for <freebsd-amd64@hub.freebsd.org>;
	Fri, 20 May 2005 19:40:06 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j4KJe6Tx096213
	for <freebsd-amd64@freefall.freebsd.org>;
	Fri, 20 May 2005 19:40:06 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j4KJe6LD096212;
	Fri, 20 May 2005 19:40:06 GMT
	(envelope-from gnats)
Date: Fri, 20 May 2005 19:40:06 GMT
Message-Id: <200505201940.j4KJe6LD096212@freefall.freebsd.org>
To: freebsd-amd64@FreeBSD.org
From: Vivek Khera <vivek@khera.org>
Subject: Re: amd64/81279: /usr/games/random returns every line
X-BeenThere: freebsd-amd64@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Vivek Khera <vivek@khera.org>
List-Id: Porting FreeBSD to the AMD64 platform <freebsd-amd64.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-amd64>
List-Post: <mailto:freebsd-amd64@freebsd.org>
List-Help: <mailto:freebsd-amd64-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-amd64>,
	<mailto:freebsd-amd64-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2005 19:40:06 -0000

The following reply was made to PR amd64/81279; it has been noted by GNATS.

From: Vivek Khera <vivek@khera.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: amd64/81279: /usr/games/random returns every line
Date: Fri, 20 May 2005 15:36:55 -0400

 --Apple-Mail-6-871661888
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain;
 	charset=US-ASCII;
 	delsp=yes;
 	format=flowed
 
 Here's a patch for /usr/src/games/random/random.c which seems to  
 solve the problem, based on Adriaan's message.
 
 
 
 --Apple-Mail-6-871661888
 Content-Transfer-Encoding: 7bit
 Content-Type: application/octet-stream;
 	x-unix-mode=0644;
 	name="random.c.patch"
 Content-Disposition: attachment;
 	filename=random.c.patch
 
 --- #random.c~	Fri May 20 15:26:50 2005
 +++ random.c	Fri May 20 15:26:50 2005
 @@ -159,7 +159,7 @@
  
  	/* Compute a random exit status between 0 and denom - 1. */
  	if (random_exit)
 -		return (int)((denom * random()) / LONG_MAX);
 +		return (int)((denom * random()) / INT_MAX);
  
  	/*
  	 * Select whether to print the first line.  (Prime the pump.)
 @@ -167,7 +167,7 @@
  	 * 0 (which has a 1 / denom chance of being true), we select the
  	 * line.
  	 */
 -	selected = (int)(denom * random() / LONG_MAX) == 0;
 +	selected = (int)(denom * random() / INT_MAX) == 0;
  	while ((ch = getchar()) != EOF) {
  		if (selected)
  			(void)putchar(ch);
 @@ -177,7 +177,7 @@
  				err(2, "stdout");
  
  			/* Now see if the next line is to be printed. */
 -			selected = (int)(denom * random() / LONG_MAX) == 0;
 +			selected = (int)(denom * random() / INT_MAX) == 0;
  		}
  	}
  	if (ferror(stdin))
 
 --Apple-Mail-6-871661888--