From owner-svn-src-user@FreeBSD.ORG Tue Oct 23 23:20:16 2012 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DFCA33C2 for ; Tue, 23 Oct 2012 23:20:16 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id 43C9C8FC0A for ; Tue, 23 Oct 2012 23:20:16 +0000 (UTC) Received: (qmail 89708 invoked from network); 24 Oct 2012 00:58:11 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 24 Oct 2012 00:58:11 -0000 Message-ID: <50872624.6060901@freebsd.org> Date: Wed, 24 Oct 2012 01:20:04 +0200 From: Andre Oppermann User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: mdf@FreeBSD.org Subject: Re: svn commit: r241889 - in user/andre/tcp_workqueue/sys: arm/arm cddl/compat/opensolaris/kern cddl/contrib/opensolaris/uts/common/dtrace cddl/contrib/opensolaris/uts/common/fs/zfs ddb dev/acpica dev/... References: <201210221418.q9MEINkr026751@svn.freebsd.org> <20121023032743.K2804@besplex.bde.org> <508664C7.3080206@freebsd.org> <201210230853.56549.jhb@freebsd.org> <5086AC94.2090700@freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@freebsd.org, Bruce Evans , John Baldwin , svn-src-user@freebsd.org X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2012 23:20:16 -0000 On 24.10.2012 00:15, mdf@FreeBSD.org wrote: > On Tue, Oct 23, 2012 at 7:41 AM, Andre Oppermann wrote: >> Struct mtx and MTX_SYSINIT always occur as pair next to each other. > > That doesn't matter. Language basics like variable definitions should > not be obscured by macros. It either takes longer to figure out what > a variable is (because one needs to look up the definition of the > macro) or makes it almost impossible (because now e.g. cscope doesn't > know this is a variable definition. Sigh, cscope doesn't expand macros? Is there a way to do the cache line alignment in a sane way without littering __aligned(CACHE_LINE_SIZE) all over the place? -- Andre