From owner-svn-src-head@freebsd.org Mon Jul 23 17:27:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8FC2E105097B; Mon, 23 Jul 2018 17:27:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6856A86285; Mon, 23 Jul 2018 17:27:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 7A98310B45D; Mon, 23 Jul 2018 13:27:37 -0400 (EDT) Subject: Re: svn commit: r336439 - in head: share/man/man9 sys/crypto/aesni sys/crypto/armv8 sys/crypto/blake2 sys/crypto/ccp sys/crypto/via sys/dev/cesa sys/dev/cxgbe/crypto sys/dev/hifn sys/dev/safe sys/dev/s... To: Conrad Meyer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807180056.w6I0uPb6000705@repo.freebsd.org> From: John Baldwin Message-ID: <64ecf6f4-93ff-a8e0-9617-d299d5e52e50@FreeBSD.org> Date: Mon, 23 Jul 2018 10:27:36 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807180056.w6I0uPb6000705@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 23 Jul 2018 13:27:37 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jul 2018 17:27:38 -0000 On 7/17/18 5:56 PM, Conrad Meyer wrote: > Author: cem > Date: Wed Jul 18 00:56:25 2018 > New Revision: 336439 > URL: https://svnweb.freebsd.org/changeset/base/336439 > > Log: > OpenCrypto: Convert sessions to opaque handles instead of integers > > Track session objects in the framework, and pass handles between the > framework (OCF), consumers, and drivers. Avoid redundancy and complexity in > individual drivers by allocating session memory in the framework and > providing it to drivers in ::newsession(). > > Session handles are no longer integers with information encoded in various > high bits. Use of the CRYPTO_SESID2FOO() macros should be replaced with the > appropriate crypto_ses2foo() function on the opaque session handle. > > Convert OCF drivers (in particular, cryptosoft, as well as myriad others) to > the opaque handle interface. Discard existing session tracking as much as > possible (quick pass). There may be additional code ripe for deletion. > > Convert OCF consumers (ipsec, geom_eli, krb5, cryptodev) to handle-style > interface. The conversion is largely mechnical. > > The change is documented in crypto.9. > > Inspired by > https://lists.freebsd.org/pipermail/freebsd-arch/2018-January/018835.html . > > No objection from: ae (ipsec portion) > Reported by: jhb And there was much rejoicing. Thanks for doing this Conrad. -- John Baldwin